profectus/Profectus
Template
1
0
Fork 4
Code Issues 38 Pull requests 6 Projects 2 Releases Packages Wiki Activity Actions

calculateMaxAffordable isn't fully calculating up to directSum #70

New issue
Open
opened 2024-02-23 17:02:20 +00:00 by escapee · 0 comments
escapee commented 2024-02-23 17:02:20 +00:00
Collaborator
Copy link

The calculateMaxAffordable calculations seem to be limited by the preSumAffordable check, which is appearing to be a redundant condition regardless.

  • Make sure existing tests still pass if the check is removed
  • Add more tests specifically around the behavior of this check
The calculateMaxAffordable calculations seem to be limited by the [preSumAffordable](https://code.incremental.social/profectus/Profectus/src/branch/main/src/game/formulas/formulas.ts#L1490) check, which is appearing to be a redundant condition regardless. - [ ] Make sure existing tests still pass if the check is removed - [ ] Add more tests specifically around the behavior of this check
escapee self-assigned this 2024-02-23 17:02:20 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/ure-rewrite
pages
ducdat0507/patch-1
feature/requirements-refactor
jakub791/main
fix/lazy-proxy-typing
gh-pages
No results found.
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
escapee
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: profectus/Profectus#70
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?