From 3acb68e5e48bb10aff67ad552e40f3b3aeb9dcc1 Mon Sep 17 00:00:00 2001 From: Yarden Shoham Date: Tue, 12 Mar 2024 06:29:51 +0200 Subject: [PATCH] Remove jQuery AJAX from the issue branch reference selection (#29722) - Replaced a single jQuery AJAX instance with our fetch wrapper - Tested the issue branch reference selection and it works as before # Demo using `fetch` instead of jQuery AJAX ![demo](https://github.com/go-gitea/gitea/assets/20454870/7e195632-41f8-494b-b599-f6291860f330) Signed-off-by: Yarden Shoham (cherry picked from commit 75a9f61f89caada64f6398130844281e4f088a73) --- web_src/js/features/repo-legacy.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/web_src/js/features/repo-legacy.js b/web_src/js/features/repo-legacy.js index 8fcc78c177..60950fd171 100644 --- a/web_src/js/features/repo-legacy.js +++ b/web_src/js/features/repo-legacy.js @@ -24,6 +24,7 @@ import {initRepoPullRequestCommitStatus} from './repo-issue-pr-status.js'; import {hideElem, showElem} from '../utils/dom.js'; import {getComboMarkdownEditor, initComboMarkdownEditor} from './comp/ComboMarkdownEditor.js'; import {attachRefIssueContextPopup} from './contextpopup.js'; +import {POST} from '../modules/fetch.js'; const {csrfToken} = window.config; @@ -65,7 +66,7 @@ export function initRepoCommentForm() { const $selectBranch = $('.ui.select-branch'); const $branchMenu = $selectBranch.find('.reference-list-menu'); const $isNewIssue = $branchMenu.hasClass('new-issue'); - $branchMenu.find('.item:not(.no-select)').on('click', function () { + $branchMenu.find('.item:not(.no-select)').on('click', async function () { const selectedValue = $(this).data('id'); const editMode = $('#editing_mode').val(); $($(this).data('id-selector')).val(selectedValue); @@ -76,7 +77,14 @@ export function initRepoCommentForm() { if (editMode === 'true') { const form = $('#update_issueref_form'); - $.post(form.attr('action'), {_csrf: csrfToken, ref: selectedValue}, () => window.location.reload()); + const params = new URLSearchParams(); + params.append('ref', selectedValue); + try { + await POST(form.attr('action'), {data: params}); + window.location.reload(); + } catch (error) { + console.error('Error:', error); + } } else if (editMode === '') { $selectBranch.find('.ui .branch-name').text(selectedValue); }