thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions 3
forgejo/modules
History
Giteabot 88bde31515
Fix Actions being enabled accidentally (#24802) (#24810) 
Backport #24802 by @wolfogre

Regression of #24536. If the user doesn't explicitly disable Actions, it
will be enabled.

1. Gitea will call `loadRepositoryFrom` before `loadActionsFrom`.

25d4f95df2/modules/setting/setting.go (L234-L237)
2. In `loadRepositoryFrom`,
`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` will set
`actions.ENABLED` with `true`.

25d4f95df2/modules/setting/repository.go (L313-L315)
3. In `loadActionsFrom`, `rootCfg.Section("actions")` will get a section
with Actions enabled.

25d4f95df2/modules/setting/actions.go (L23-L26)

Although the cause of the problem was using `true` by copy-paste
mistake, it also surprised me that
**`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` doesn't
only read, but also write.**

Co-authored-by: Jason Song <i@wolfogre.com>
(cherry picked from commit b369ed579d)
2023-05-23 07:42:34 +02:00
..
actions [BRANDING] lookup .forgejo/workflows before .gitea/workflows 2023-05-10 11:05:22 +02:00
activitypub Add Chef package registry (#22554) 2023-02-06 09:49:21 +08:00
analyze
auth [SECURITY] default to pbkdf2 with 320,000 iterations 2023-05-10 09:20:14 +02:00
avatar Unify hashing for avatar (#22289) 2023-01-02 22:46:39 +01:00
base
cache Update redis library to support redis v7 (#24114) (#24156) 2023-04-17 02:34:59 -04:00
charset Fix isAllowed of escapeStreamer (#22814) 2023-02-09 20:51:36 +08:00
container
context Fix safari cookie session bug (#24772) 2023-05-23 07:42:34 +02:00
csv Add context when rendering labels or emojis (#23281) (#23319) 2023-03-06 10:32:40 -06:00
doctor Check LFS/Packages settings in dump and doctor command (#23631) (#23730) 2023-03-27 16:28:22 +08:00
emoji Fix unstable emoji sort (#22346) 2023-01-05 13:58:51 +02:00
eventsource Move convert package to services (#22264) 2022-12-29 10:57:15 +08:00
generate
git Remove Repository.getFilesChanged to fix Actions paths and paths-ignore filter (#23920) (#23969) 2023-04-08 16:16:21 +08:00
gitgraph Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
graceful
hcaptcha Consume hcaptcha and pwn deps (#22610) 2023-01-29 09:49:51 -06:00
highlight Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
hostmatcher
html
httpcache [BRANDING] add X-Forgejo-* headers 2023-05-10 11:05:22 +02:00
httplib
indexer Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
issue/template Allow issue templates to not render title (#22589) 2023-01-26 22:45:49 -06:00
json Update gitea-vet to check FSFE REUSE (#22004) 2022-12-02 22:14:57 +08:00
label Make label templates have consistent behavior and priority (#23749) (#24071) 2023-04-12 16:05:10 +02:00
lfs Make minio package support legacy MD5 checksum (#23768) (#23770) 2023-03-29 00:02:13 +08:00
log Improve trace logging for pulls and processes (#22633) 2023-02-03 18:11:48 -05:00
markup Add context when rendering labels or emojis (#23281) (#23319) 2023-03-06 10:32:40 -06:00
mcaptcha
metrics include build info in Prometheus metrics (#22819) 2023-02-08 19:54:01 +02:00
migration Scoped labels (#22585) 2023-02-18 21:17:39 +02:00
mirror
nosql Update redis library to support redis v7 (#24114) (#24156) 2023-04-17 02:34:59 -04:00
notification Implement actions (#21937) 2023-01-31 09:45:19 +08:00
options Introduce path Clean/Join helper functions, partially backport&refactor (#23495) (#23607) 2023-03-22 19:56:20 +08:00
packages Use import of OCI structs (#22765) 2023-02-06 10:07:09 +00:00
paginator Update gitea-vet to check FSFE REUSE (#22004) 2022-12-02 22:14:57 +08:00
pprof
private Implement actions (#21937) 2023-01-31 09:45:19 +08:00
process Improve trace logging for pulls and processes (#22633) 2023-02-03 18:11:48 -05:00
proxy Use proxy for pull mirror (#22771) 2023-02-11 08:39:50 +08:00
proxyprotocol
public
queue Skip known flaky queue tests on CI environment (#24443) 2023-04-30 15:25:42 -04:00
recaptcha
references Use correct captured group range when parsing cross-reference (#22672) 2023-01-31 10:08:05 +01:00
regexplru
repository Make label templates have consistent behavior and priority (#23749) (#24071) 2023-04-12 16:05:10 +02:00
secret Improve decryption failure message (#24573) (#24575) 2023-05-07 22:12:32 +08:00
session Update redis library to support redis v7 (#24114) (#24156) 2023-04-17 02:34:59 -04:00
setting Fix Actions being enabled accidentally (#24802) (#24810) 2023-05-23 07:42:34 +02:00
sitemap Fix sitemap (#22272) 2022-12-30 23:31:00 +08:00
ssh
storage Make minio package support legacy MD5 checksum (#23768) (#23770) 2023-03-29 00:02:13 +08:00
structs [BRANDING] define the forgejo webhook type 2023-05-10 11:05:22 +02:00
svg
sync
system
templates Fix custom mailer template on Windows (#24081) 2023-04-12 12:16:40 -04:00
test Rename repo.GetOwner to repo.LoadOwner (#22967) 2023-02-18 20:11:03 +08:00
timeutil Make time tooltips interactive (#23526) (#23527) 2023-03-16 16:23:11 -05:00
translation
turnstile Add new captcha: cloudflare turnstile (#22369) 2023-02-05 15:29:03 +08:00
typesniffer Do not recognize text files as audio (#23355) (#23368) 2023-03-08 16:03:05 +08:00
updatechecker [PRIVACY] Add a DNS method to fetch new updates 2023-05-10 11:04:40 +02:00
upload
uri
user
util Fix cases.Title crash for concurrency (#23885) (#23903) 2023-04-04 01:26:14 +02:00
validation Map OIDC groups to Orgs/Teams (#21441) 2023-02-08 14:44:42 +08:00
watcher
web Map OIDC groups to Orgs/Teams (#21441) 2023-02-08 14:44:42 +08:00
webhook [BRANDING] define the forgejo webhook type 2023-05-10 11:05:22 +02:00