thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions 3
forgejo/web_src/js/features
History
zeripath 72fa108cbc
Fix review excerpt (#18502) (#18530) 
Backport #18502

Currently the "File Changed" tab of a PR is somehow broken. This is also true for the current release 1.16.0.

When you are on the "File Changed" tab, and want to look at code excerpt before or after the code changes, the layout breaks. You can test this on try.gitea.io here: https://try.gitea.io/testnotexisting/magic_enum/pulls/2/files

The problem occurs for the unified view and for the split view.

Kind of the same problem was there for commenting a line of code, this was fixed in #18321 and #18403.

For consistency, I changed the solution of #18321, I removed the ``colspan`` and instead added a ``<td>``. The goal was to have code similarly with the split view.

Also the separator line in the split view was in the wrong column, this was fixed too.* more consistent unified review comment

Fix #18516

Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: confusedsushi <confused.sushi@googlemail.com>
2022-02-02 08:38:28 +00:00
..
comp Make the height of the editor in Review Box smaller (4 lines as GitHub) (#18319) 2022-01-19 00:57:57 +08:00
admin-common.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 2021-10-21 15:37:43 +08:00
admin-emails.js Split index.js to separate files (#17315) 2021-10-17 01:28:04 +08:00
admin-users.js Frontend refactor: move Vue related code from index.js to components dir, and remove unused codes. (#17301) 2021-10-15 10:35:26 +08:00
clipboard.js Add new JS linter rules (#17699) 2021-11-22 16:19:01 +08:00
codeeditor.js Add new JS linter rules (#17699) 2021-11-22 16:19:01 +08:00
colorpicker.js Move jquery-minicolors to npm/webpack (#12305) 2020-07-29 14:44:23 -04:00
common-global.js Revert "Prevent possible XSS when using jQuery (#18289)" (#18293) 2022-01-16 11:19:26 +00:00
common-issue.js Update JS dependencies, adjust eslint config (#17904) 2021-12-04 14:43:14 +08:00
common-organization.js Split index.js to separate files (#17315) 2021-10-17 01:28:04 +08:00
contextpopup.js Fix context popup error (#17398) 2021-10-22 22:34:01 +08:00
dropzone.js Update JS dependencies (#17611) 2021-11-11 09:52:16 +08:00
emoji.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 2021-10-21 15:37:43 +08:00
eventsource.sharedworker.js Update JS dependencies (#16708) 2021-08-17 01:32:48 -04:00
heatmap.js Add new JS linter rules (#17699) 2021-11-22 16:19:01 +08:00
imagediff.js Improve async/await usage, and sort init calls in index.js (#17386) 2021-11-09 17:27:25 +08:00
install.js Refactor install page (db type) (#17919) 2021-12-07 13:44:08 +08:00
notification.js Fix some incorrect async functions, improve frontend document. (#17597) 2021-11-12 20:37:45 +08:00
org-team.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 2021-10-21 15:37:43 +08:00
repo-branch.js Revert "Prevent possible XSS when using jQuery (#18289)" (#18293) 2022-01-16 11:19:26 +00:00
repo-code.js Add new JS linter rules (#17699) 2021-11-22 16:19:01 +08:00
repo-commit.js Improve ellipsis buttons (#17773) 2021-11-22 21:44:38 -05:00
repo-common.js Revert "Prevent possible XSS when using jQuery (#18289)" (#18293) 2022-01-16 11:19:26 +00:00
repo-diff.js Fix PR comments UI (#18323) 2022-01-19 01:28:38 +08:00
repo-editor.js Sanitize user-input on file name (#17666) 2021-11-17 18:08:25 +00:00
repo-graph.js Fix some incorrect async functions, improve frontend document. (#17597) 2021-11-12 20:37:45 +08:00
repo-home.js Add new JS linter rules (#17699) 2021-11-22 16:19:01 +08:00
repo-issue-content.js Fix PR comments UI (#18323) 2022-01-19 01:28:38 +08:00
repo-issue.js Fix review excerpt (#18502) (#18530) 2022-02-02 08:38:28 +00:00
repo-legacy.js Revert "Prevent possible XSS when using jQuery (#18289)" (#18293) 2022-01-16 11:19:26 +00:00
repo-migrate.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 2021-10-21 15:37:43 +08:00
repo-migration.js Improve async/await usage, and sort init calls in index.js (#17386) 2021-11-09 17:27:25 +08:00
repo-projects.js Support sorting for project board issuses (#17152) 2021-12-08 14:57:18 +08:00
repo-release.js Load EasyMDE/CodeMirror dynamically, remove RequireEasyMDE (#18069) 2022-01-05 13:17:25 +01:00
repo-settings.js Revert "Prevent possible XSS when using jQuery (#18289)" (#18293) 2022-01-16 11:19:26 +00:00
repo-template.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 2021-10-21 15:37:43 +08:00
repo-unicode-escape.js Add warning for BIDI characters in page renders and in diffs (#17562) 2022-01-07 02:18:52 +01:00
repo-wiki.js Load EasyMDE/CodeMirror dynamically, remove RequireEasyMDE (#18069) 2022-01-05 13:17:25 +01:00
serviceworker.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 2021-10-21 15:37:43 +08:00
sshkey-helper.js Split index.js to separate files (#17315) 2021-10-17 01:28:04 +08:00
stopwatch.js Fix some incorrect async functions, improve frontend document. (#17597) 2021-11-12 20:37:45 +08:00
tablesort.js Added missing data- prefix. (#17884) 2021-12-03 00:36:00 +08:00
tribute.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 2021-10-21 15:37:43 +08:00
user-auth-webauthn.js Prevent showing webauthn error for every time visiting /user/settings/security (#18385) (#18386) 2022-01-25 00:11:49 +00:00
user-auth.js Split index.js to separate files (#17315) 2021-10-17 01:28:04 +08:00
user-settings.js Split index.js to separate files (#17315) 2021-10-17 01:28:04 +08:00