Make requirements support buying max

src/game/formulas.ts

@@ -1992,7 +1992,7 @@ export default class Formula<T extends [FormulaSource] | FormulaSource[]> {
 }
 
 /**
- * Utility for calculating the maximum amount of purchases possible with a given formula and resource. If {@ref spendResources} is changed to false, the calculation will be much faster with higher numbers. Returns a ref of how many can be bought, as well as how much that will cost.
+ * Utility for calculating the maximum amount of purchases possible with a given formula and resource. If {@ref spendResources} is changed to false, the calculation will be much faster with higher numbers.
  * @param formula The formula to use for calculating buy max from
  * @param resource The resource used when purchasing (is only read from)
  * @param spendResources Whether or not to count spent resources on each purchase or not
@@ -2001,19 +2001,19 @@ export function calculateMaxAffordable(
     formula: InvertibleFormula,
     resource: Resource,
     spendResources?: true
-): { maxAffordable: ComputedRef<DecimalSource>; cost: ComputedRef<DecimalSource> };
+): ComputedRef<DecimalSource>;
 export function calculateMaxAffordable(
     formula: InvertibleIntegralFormula,
     resource: Resource,
     spendResources: Computable<boolean>
-): { maxAffordable: ComputedRef<DecimalSource>; cost: ComputedRef<DecimalSource> };
+): ComputedRef<DecimalSource>;
 export function calculateMaxAffordable(
     formula: InvertibleFormula,
     resource: Resource,
     spendResources: Computable<boolean> = true
 ) {
     const computedSpendResources = convertComputable(spendResources);
-    const maxAffordable = computed(() => {
+    return computed(() => {
         if (unref(computedSpendResources)) {
             if (!formula.isIntegrable() || !formula.isIntegralInvertible()) {
                 throw "Cannot calculate max affordable of formula with non-invertible integral";
@@ -2028,13 +2028,33 @@ export function calculateMaxAffordable(
             return Decimal.floor((formula as InvertibleFormula).invert(resource.value));
         }
     });
-    const cost = computed(() => {
+}
-        const newValue = maxAffordable.value.add(unref(formula.innermostVariable) ?? 0);
+
-        if (unref(computedSpendResources)) {
+/**
+ * Utility for calculating the cost of a formula for a given amount of purchases. If {@ref spendResources} is changed to false, the calculation will be much faster with higher numbers.
+ * @param formula The formula to use for calculating buy max from
+ * @param amountToBuy The amount of purchases to calculate the cost for
+ * @param spendResources Whether or not to count spent resources on each purchase or not
+ */
+export function calculateCost(
+    formula: InvertibleFormula,
+    amountToBuy: DecimalSource,
+    spendResources?: true
+): DecimalSource;
+export function calculateCost(
+    formula: InvertibleIntegralFormula,
+    amountToBuy: DecimalSource,
+    spendResources: boolean
+): DecimalSource;
+export function calculateCost(
+    formula: InvertibleFormula,
+    amountToBuy: DecimalSource,
+    spendResources = true
+) {
+    const newValue = Decimal.add(amountToBuy, unref(formula.innermostVariable) ?? 0);
+    if (spendResources) {
         return Decimal.sub(formula.evaluateIntegral(newValue), formula.evaluateIntegral());
     } else {
         return formula.evaluate(newValue);
     }
-    });
-    return { maxAffordable, cost };
 }

src/game/requirements.tsx

@@ -11,6 +11,7 @@ import {
 import { createLazyProxy } from "util/proxies";
 import { joinJSX, renderJSX } from "util/vue";
 import { computed, unref } from "vue";
+import Formula, { calculateCost, calculateMaxAffordable, GenericFormula } from "./formulas";
 
 /**
  * An object that can be used to describe a requirement to perform some purchase or other action.
@@ -18,36 +19,33 @@ import { computed, unref } from "vue";
  */
 export interface Requirement {
     /** The display for this specific requirement. This is used for displays multiple requirements condensed. Required if {@link visibility} can be {@link Visibility.Visible}. */
-    partialDisplay?: JSXFunction;
+    partialDisplay?: (amount?: DecimalSource) => JSX.Element;
     /** The display for this specific requirement. Required if {@link visibility} can be {@link Visibility.Visible}. */
-    display?: JSXFunction;
+    display?: (amount?: DecimalSource) => JSX.Element;
     visibility: ProcessedComputable<Visibility.Visible | Visibility.None>;
-    requirementMet: ProcessedComputable<boolean>;
+    requirementMet: ProcessedComputable<DecimalSource | boolean>;
     requiresPay: ProcessedComputable<boolean>;
-    pay?: VoidFunction;
+    buyMax?: ProcessedComputable<boolean>;
+    pay?: (amount?: DecimalSource) => void;
 }
 
 export type Requirements = Requirement | Requirement[];
 
 export interface CostRequirementOptions {
     resource: Resource;
-    cost: Computable<DecimalSource>;
+    cost: Computable<DecimalSource> | GenericFormula;
     visibility?: Computable<Visibility.Visible | Visibility.None>;
-    requiresPay?: ProcessedComputable<boolean>;
+    requiresPay?: Computable<boolean>;
-    pay?: VoidFunction;
+    buyMax?: Computable<boolean>;
+    spendResources?: Computable<boolean>;
+    pay?: (amount?: DecimalSource) => void;
 }
 
-export function createCostRequirement<T extends CostRequirementOptions>(
+export function createCostRequirement<T extends CostRequirementOptions>(optionsFunc: () => T) {
-    optionsFunc: () => T
-): Requirement {
     return createLazyProxy(() => {
         const req = optionsFunc() as T & Partial<Requirement>;
 
-        req.requirementMet = computed(() =>
+        req.partialDisplay = amount => (
-            Decimal.gte(req.resource.value, unref(req.cost as ProcessedComputable<DecimalSource>))
-        );
-
-        req.partialDisplay = jsx(() => (
             <span
                 style={
                     unref(req.requirementMet as ProcessedComputable<boolean>)
@@ -57,33 +55,81 @@ export function createCostRequirement<T extends CostRequirementOptions>(
             >
                 {displayResource(
                     req.resource,
-                    unref(req.cost as ProcessedComputable<DecimalSource>)
+                    req.cost instanceof Formula
+                        ? calculateCost(
+                              req.cost,
+                              amount ?? 1,
+                              unref(
+                                  req.spendResources as ProcessedComputable<boolean> | undefined
+                              ) ?? true
+                          )
+                        : unref(req.cost as ProcessedComputable<DecimalSource>)
                 )}{" "}
                 {req.resource.displayName}
             </span>
-        ));
+        );
-        req.display = jsx(() => (
+        req.display = amount => (
             <div>
                 {unref(req.requiresPay as ProcessedComputable<boolean>) ? "Costs: " : "Requires: "}
                 {displayResource(
                     req.resource,
-                    unref(req.cost as ProcessedComputable<DecimalSource>)
+                    req.cost instanceof Formula
+                        ? calculateCost(
+                              req.cost,
+                              amount ?? 1,
+                              unref(
+                                  req.spendResources as ProcessedComputable<boolean> | undefined
+                              ) ?? true
+                          )
+                        : unref(req.cost as ProcessedComputable<DecimalSource>)
                 )}{" "}
                 {req.resource.displayName}
             </div>
-        ));
+        );
 
         processComputable(req as T, "visibility");
         setDefault(req, "visibility", Visibility.Visible);
         processComputable(req as T, "cost");
         processComputable(req as T, "requiresPay");
+        processComputable(req as T, "spendResources");
         setDefault(req, "requiresPay", true);
-        setDefault(req, "pay", function () {
+        setDefault(req, "pay", function (amount?: DecimalSource) {
-            req.resource.value = Decimal.sub(
+            const cost =
+                req.cost instanceof Formula
+                    ? calculateCost(
+                          req.cost,
+                          amount ?? 1,
+                          unref(req.spendResources as ProcessedComputable<boolean> | undefined) ??
+                              true
+                      )
+                    : unref(req.cost as ProcessedComputable<DecimalSource>);
+            req.resource.value = Decimal.sub(req.resource.value, cost).max(0);
+        });
+        processComputable(req as T, "buyMax");
+
+        if (
+            "buyMax" in req &&
+            req.buyMax !== false &&
+            req.cost instanceof Formula &&
+            req.cost.isInvertible()
+        ) {
+            req.requirementMet = calculateMaxAffordable(
+                req.cost,
+                req.resource,
+                unref(req.spendResources as ProcessedComputable<boolean> | undefined) ?? true
+            );
+        } else {
+            req.requirementMet = computed(() => {
+                if (req.cost instanceof Formula) {
+                    return Decimal.gte(req.resource.value, req.cost.evaluate());
+                } else {
+                    return Decimal.gte(
                         req.resource.value,
                         unref(req.cost as ProcessedComputable<DecimalSource>)
-            ).max(0);
+                    );
+                }
             });
+        }
 
         return req as Requirement;
     });
@@ -112,14 +158,26 @@ export function createBooleanRequirement(
     }));
 }
 
-export function requirementsMet(requirements: Requirements) {
+export function requirementsMet(requirements: Requirements): boolean {
     if (isArray(requirements)) {
-        return requirements.every(r => unref(r.requirementMet));
+        return requirements.every(requirementsMet);
     }
-    return unref(requirements.requirementMet);
+    const reqsMet = unref(requirements.requirementMet);
+    return typeof reqsMet === "boolean" ? reqsMet : Decimal.gt(reqsMet, 0);
 }
 
-export function displayRequirements(requirements: Requirements) {
+export function maxRequirementsMet(requirements: Requirements): DecimalSource {
+    if (isArray(requirements)) {
+        return requirements.map(maxRequirementsMet).reduce(Decimal.min);
+    }
+    const reqsMet = unref(requirements.requirementMet);
+    if (typeof reqsMet === "boolean") {
+        return reqsMet ? Infinity : 0;
+    }
+    return reqsMet;
+}
+
+export function displayRequirements(requirements: Requirements, amount: DecimalSource = 1) {
     if (isArray(requirements)) {
         requirements = requirements.filter(r => unref(r.visibility) === Visibility.Visible);
         if (requirements.length === 1) {
@@ -136,7 +194,7 @@ export function displayRequirements(requirements: Requirements) {
                     <div>
                         Costs:{" "}
                         {joinJSX(
-                            withCosts.map(r => r.partialDisplay!()),
+                            withCosts.map(r => r.partialDisplay!(amount)),
                             <>, </>
                         )}
                     </div>
@@ -145,7 +203,7 @@ export function displayRequirements(requirements: Requirements) {
                     <div>
                         Requires:{" "}
                         {joinJSX(
-                            withoutCosts.map(r => r.partialDisplay!()),
+                            withoutCosts.map(r => r.partialDisplay!(amount)),
                             <>, </>
                         )}
                     </div>
@@ -156,10 +214,11 @@ export function displayRequirements(requirements: Requirements) {
     return requirements.display?.() ?? <></>;
 }
 
-export function payRequirements(requirements: Requirements) {
+export function payRequirements(requirements: Requirements, buyMax = false) {
+    const amount = buyMax ? maxRequirementsMet(requirements) : 1;
     if (isArray(requirements)) {
-        requirements.filter(r => unref(r.requiresPay)).forEach(r => r.pay?.());
+        requirements.filter(r => unref(r.requiresPay)).forEach(r => r.pay?.(amount));
     } else if (unref(requirements.requiresPay)) {
-        requirements.pay?.();
+        requirements.pay?.(amount);
     }
 }

tests/game/formulas.test.ts

@@ -1,5 +1,6 @@
 import { createResource, Resource } from "features/resources/resource";
 import Formula, {
+    calculateCost,
     calculateMaxAffordable,
     GenericFormula,
     InvertibleFormula,
@@ -983,45 +984,32 @@ describe("Buy Max", () => {
     });
     describe("With spending", () => {
         test("Throws on formula with non-invertible integral", () => {
-            const { maxAffordable, cost } = calculateMaxAffordable(
+            const maxAffordable = calculateMaxAffordable(Formula.neg(10), resource, false);
-                Formula.neg(10),
-                resource,
-                false
-            );
             expect(() => maxAffordable.value).toThrow();
-            expect(() => cost.value).toThrow();
         });
         // https://www.desmos.com/calculator/5vgletdc1p
         test("Calculates max affordable and cost correctly", () => {
             const variable = Formula.variable(10);
-            const { maxAffordable, cost } = calculateMaxAffordable(
+            const formula = Formula.pow(1.05, variable);
-                Formula.pow(1.05, variable),
+            const maxAffordable = calculateMaxAffordable(formula, resource, false);
-                resource,
-                false
-            );
             expect(maxAffordable.value).compare_tolerance(47);
-            expect(cost.value).compare_tolerance(Decimal.pow(1.05, 47));
+            expect(calculateCost(formula, maxAffordable.value, false)).compare_tolerance(
+                Decimal.pow(1.05, 47)
+            );
         });
     });
     describe("Without spending", () => {
         test("Throws on non-invertible formula", () => {
-            const { maxAffordable, cost } = calculateMaxAffordable(
+            const maxAffordable = calculateMaxAffordable(Formula.abs(10), resource, false);
-                Formula.abs(10),
-                resource,
-                false
-            );
             expect(() => maxAffordable.value).toThrow();
-            expect(() => cost.value).toThrow();
         });
         // https://www.desmos.com/calculator/5vgletdc1p
         test("Calculates max affordable and cost correctly", () => {
             const variable = Formula.variable(10);
-            const { maxAffordable, cost } = calculateMaxAffordable(
+            const formula = Formula.pow(1.05, variable);
-                Formula.pow(1.05, variable),
+            const maxAffordable = calculateMaxAffordable(formula, resource);
-                resource
-            );
             expect(maxAffordable.value).compare_tolerance(7);
-            expect(cost.value).compare_tolerance(7.35);
+            expect(calculateCost(formula, maxAffordable.value)).compare_tolerance(7.35);
         });
     });
 });