thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Remove jQuery .attr from the image diff (#29917)

Browse source 
- Switched from jQuery `.attr` to plain javascript `.setAttribute`
- Tested the image diff functionality and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
(cherry picked from commit cb98e27992cae7d62e527e922cae3c0f738a7cab)
This commit is contained in:
Yarden Shoham 2024-03-20 01:49:15 +02:00 committed by Earl Warren
parent f9546aa0f2
commit 32cef22bfd
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
web_src/js/features/imagediff.js
View file

@ -70,7 +70,7 @@ export function initImageDiff() {
$('.image-diff:not([data-image-diff-loaded])').each(async function() { $('.image-diff:not([data-image-diff-loaded])').each(async function() {
const $container = $(this); const $container = $(this);
$container.attr('data-image-diff-loaded', 'true'); this.setAttribute('data-image-diff-loaded', 'true');
// the container may be hidden by "viewed" checkbox, so use the parent's width for reference // the container may be hidden by "viewed" checkbox, so use the parent's width for reference
const diffContainerWidth = Math.max($container.closest('.diff-file-box').width() - 300, 100); const diffContainerWidth = Math.max($container.closest('.diff-file-box').width() - 300, 100);