thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Return 404 when user is not found on avatar (#21476) (#21477)

Browse source 
- Backport #21476
- Instead of returning a 500 Internal Server when the user wasn't found,
return 404 Not found.
This commit is contained in:
Gusted 2022-10-16 16:56:58 +00:00 committed by GitHub
parent f48fda8eef
commit 3f032759ed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
routers/web/user/avatar.go
View file

@ -31,6 +31,10 @@ func AvatarByUserName(ctx *context.Context) {
if strings.ToLower(userName) != "ghost" { if strings.ToLower(userName) != "ghost" {
var err error var err error
if user, err = user_model.GetUserByName(ctx, userName); err != nil { if user, err = user_model.GetUserByName(ctx, userName); err != nil {
if user_model.IsErrUserNotExist(err) {
ctx.NotFound("GetUserByName", err)
return
}
ctx.ServerError("Invalid user: "+userName, err) ctx.ServerError("Invalid user: "+userName, err)
return return
} }