thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions

follow up on #2367: rel="nofollow" on in-list labels

Browse source 
The forgejo/forgejo#2367 pull requests added rel="nofollow" on filters in the
menu, this commit adds it on the labels in the listing and a few other places.
This commit is contained in:
Chl 2024-08-15 21:28:49 +02:00
parent 44002a6399
commit 3fab07e0bc
No known key found for this signature in database
GPG key ID: 80012B734F21B934
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/templates/util_render.go
View file

@ -245,7 +245,7 @@ func RenderLabels(ctx context.Context, locale translation.Locale, labels []*issu
if isPull { if isPull {
issuesOrPull = "pulls" issuesOrPull = "pulls"
} }
htmlCode += fmt.Sprintf("<a href='%s/%s?labels=%d'>%s</a> ", htmlCode += fmt.Sprintf("<a href='%s/%s?labels=%d' rel='nofollow'>%s</a> ",
repoLink, issuesOrPull, label.ID, RenderLabel(ctx, locale, label)) repoLink, issuesOrPull, label.ID, RenderLabel(ctx, locale, label))
} }
htmlCode += "</span>" htmlCode += "</span>"

1
templates/repo/issue/labels/label.tmpl
View file

@ -2,6 +2,7 @@
class="item {{if not .label.IsChecked}}tw-hidden{{end}}" class="item {{if not .label.IsChecked}}tw-hidden{{end}}"
id="label_{{.label.ID}}" id="label_{{.label.ID}}"
href="{{.root.RepoLink}}/{{if or .root.IsPull .root.Issue.IsPull}}pulls{{else}}issues{{end}}?labels={{.label.ID}}"{{/* FIXME: use .root.Issue.Link or create .root.Link */}} href="{{.root.RepoLink}}/{{if or .root.IsPull .root.Issue.IsPull}}pulls{{else}}issues{{end}}?labels={{.label.ID}}"{{/* FIXME: use .root.Issue.Link or create .root.Link */}}
rel="nofollow"
> >
{{- RenderLabel $.Context ctx.Locale .label -}} {{- RenderLabel $.Context ctx.Locale .label -}}
</a> </a>

2
templates/shared/issuelist.tmpl
View file

@ -21,7 +21,7 @@
{{end}} {{end}}
<span class="labels-list tw-ml-1"> <span class="labels-list tw-ml-1">
{{range .Labels}} {{range .Labels}}
<a href="?q={{$.Keyword}}&type={{$.ViewType}}&state={{$.State}}&labels={{.ID}}{{if ne $.listType "milestone"}}&milestone={{$.MilestoneID}}{{end}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}&fuzzy={{$.IsFuzzy}}{{if $.ShowArchivedLabels}}&archived=true{{end}}">{{RenderLabel $.Context ctx.Locale .}}</a> <a href="?q={{$.Keyword}}&type={{$.ViewType}}&state={{$.State}}&labels={{.ID}}{{if ne $.listType "milestone"}}&milestone={{$.MilestoneID}}{{end}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}&fuzzy={{$.IsFuzzy}}{{if $.ShowArchivedLabels}}&archived=true{{end}}" rel="nofollow">{{RenderLabel $.Context ctx.Locale .}}</a>
{{end}} {{end}}
</span> </span>
</div> </div>