thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Add fullTextSearch to dropdowns by default (#14694)

Browse source 
This PR adds `fullTextSearch: 'exact'` to most dropdown
invocations meaning that if there is a search box for the
dropdown it will automatically do a fullTextSearch looking
for the provided fragment instead of starting at the beginning

We should consider changing other places that use
`fullTextSearch: true` to `'exact'` because these will be using a
fuzzy-textual search that doesn't necessarily return the
expected results.

Fix #14689

Signed-off-by: Andrew Thornton <art27@cantab.net>
This commit is contained in:
zeripath 2021-02-16 03:03:32 +00:00 committed by GitHub
parent 0a9a484e1e
commit 60ef2a7c67
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
web_src/js/features/gitgraph.js
View file

@ -74,6 +74,7 @@ export default async function initGitGraph() {
$('#flow-select-refs-dropdown').dropdown('set selected', dropdownSelected); $('#flow-select-refs-dropdown').dropdown('set selected', dropdownSelected);
$('#flow-select-refs-dropdown').dropdown({ $('#flow-select-refs-dropdown').dropdown({
clearable: true, clearable: true,
fullTextSeach: 'exact',
onRemove(toRemove) { onRemove(toRemove) {
if (toRemove === '...flow-hide-pr-refs') { if (toRemove === '...flow-hide-pr-refs') {
params.delete('hide-pr-refs'); params.delete('hide-pr-refs');

14
web_src/js/index.js
View file

@ -2408,18 +2408,23 @@ $(document).ready(async () => {
}); });
// Semantic UI modules. // Semantic UI modules.
$('.dropdown:not(.custom)').dropdown(); $('.dropdown:not(.custom)').dropdown({
fullTextSearch: 'exact'
});
$('.jump.dropdown').dropdown({ $('.jump.dropdown').dropdown({
action: 'hide', action: 'hide',
onShow() { onShow() {
$('.poping.up').popup('hide'); $('.poping.up').popup('hide');
} },
fullTextSearch: 'exact'
}); });
$('.slide.up.dropdown').dropdown({ $('.slide.up.dropdown').dropdown({
transition: 'slide up' transition: 'slide up',
fullTextSearch: 'exact'
}); });
$('.upward.dropdown').dropdown({ $('.upward.dropdown').dropdown({
direction: 'upward' direction: 'upward',
fullTextSearch: 'exact'
}); });
$('.ui.accordion').accordion(); $('.ui.accordion').accordion();
$('.ui.checkbox').checkbox(); $('.ui.checkbox').checkbox();
@ -3465,6 +3470,7 @@ function initTopicbar() {
topicDropdown.dropdown({ topicDropdown.dropdown({
allowAdditions: true, allowAdditions: true,
forceSelection: false, forceSelection: false,
fullTextSearch: 'exact',
fields: {name: 'description', value: 'data-value'}, fields: {name: 'description', value: 'data-value'},
saveRemoteData: false, saveRemoteData: false,
label: { label: {