thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Reduce unnecessary database queries on actions table (#30509)

Browse source 
(cherry picked from commit 6f7d70fb3d2624507c3ccd5640f6d1837259c27d)
This commit is contained in:
Lunny Xiao 2024-04-17 09:25:03 +08:00 committed by Gergely Nagy
parent cfb8617fc8
commit 77c4a5e95b
No known key found for this signature in database
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
models/activities/action_list.go
View file

@ -83,6 +83,9 @@ func (actions ActionList) loadRepoOwner(ctx context.Context, userMap map[int64]*
_, alreadyLoaded := userMap[action.Repo.OwnerID] _, alreadyLoaded := userMap[action.Repo.OwnerID]
return action.Repo.OwnerID, !alreadyLoaded return action.Repo.OwnerID, !alreadyLoaded
}) })
if len(missingUserIDs) == 0 {
return nil
}
if err := db.GetEngine(ctx). if err := db.GetEngine(ctx).
In("id", missingUserIDs). In("id", missingUserIDs).
@ -129,6 +132,9 @@ func (actions ActionList) LoadComments(ctx context.Context) error {
commentIDs = append(commentIDs, action.CommentID) commentIDs = append(commentIDs, action.CommentID)
} }
} }
if len(commentIDs) == 0 {
return nil
}
commentsMap := make(map[int64]*issues_model.Comment, len(commentIDs)) commentsMap := make(map[int64]*issues_model.Comment, len(commentIDs))
if err := db.GetEngine(ctx).In("id", commentIDs).Find(&commentsMap); err != nil { if err := db.GetEngine(ctx).In("id", commentIDs).Find(&commentsMap); err != nil {