thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions

Fix height for sticky head on large screen on PR page (#23111) (#23124)

Browse source 
Backport #23111

Right now on the PR 'File Change' Tab, the file title header sticky to
the top on large screens has wrong height, resulting in wrong ui
behavior when scrolling down. This PR is to fix this.

Before:

<img width="964" alt="截屏2023-02-24 17 12 29"
src="https://user-images.githubusercontent.com/17645053/221140409-025c4a84-6bbe-4b5b-a13f-bd2b79063522.png">

After:
<img width="1430" alt="截屏2023-02-24 21 10 12"
src="https://user-images.githubusercontent.com/17645053/221186750-0344d652-4610-4a90-a4c0-7f6269f950d6.png">

---------

Co-authored-by: HesterG <hestergong@gmail.com>
Co-authored-by: Andrew Thornton <art27@cantab.net>
This commit is contained in:
Yarden Shoham 2023-02-24 18:35:59 +02:00 committed by GitHub
parent 48eb5ac685
commit 8adc6a188e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
web_src/less/_repository.less
View file

@ -3218,17 +3218,9 @@ td.blob-excerpt {
.ui.attached.header.diff-file-header { .ui.attached.header.diff-file-header {
&.sticky-2nd-row { &.sticky-2nd-row {
position: sticky; position: sticky;
top: 46px; top: 77px;
z-index: 7; z-index: 7;
@media @mediaMd {
top: 77px;
}
@media @mediaSm {
top: 77px;
}
@media (max-width: 480px) { @media (max-width: 480px) {
position: static; position: static;
} }