Prefer variables over subprocesses (#26690) (#26693)

Backport #26690 by @thomas-mc-work

… because it doesn't require a separate shell, spawning a process which
cost unnecessary resources and takes time.

Co-authored-by: Thomas McWork <thomas.mc.work@posteo.de>
This commit is contained in:
Giteabot 2023-08-23 20:53:44 +08:00 committed by GitHub
parent 2f4de240c1
commit ecfed9e298
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -81,7 +81,7 @@ docker run --entrypoint="" --rm -it gitea/act_runner:latest act_runner generate-
When you are using the docker image, you can specify the configuration file by using the `CONFIG_FILE` environment variable. Make sure that the file is mounted into the container as a volume: When you are using the docker image, you can specify the configuration file by using the `CONFIG_FILE` environment variable. Make sure that the file is mounted into the container as a volume:
```bash ```bash
docker run -v $(pwd)/config.yaml:/config.yaml -e CONFIG_FILE=/config.yaml ... docker run -v $PWD/config.yaml:/config.yaml -e CONFIG_FILE=/config.yaml ...
``` ```
You may notice the commands above are both incomplete, because it is not the time to run the act runner yet. You may notice the commands above are both incomplete, because it is not the time to run the act runner yet.
@ -157,8 +157,8 @@ If you are using the docker image, behaviour will be slightly different. Registr
```bash ```bash
docker run \ docker run \
-v $(pwd)/config.yaml:/config.yaml \ -v $PWD/config.yaml:/config.yaml \
-v $(pwd)/data:/data \ -v $PWD/data:/data \
-v /var/run/docker.sock:/var/run/docker.sock \ -v /var/run/docker.sock:/var/run/docker.sock \
-e CONFIG_FILE=/config.yaml \ -e CONFIG_FILE=/config.yaml \
-e GITEA_INSTANCE_URL=<instance_url> \ -e GITEA_INSTANCE_URL=<instance_url> \