forgejo/modules/doctor
zeripath 0d25292fbc
Prevent panic in doctor command when running default checks (#21791) (#21807)
Backport #21791

There was a bug introduced in #21352 due to a change of behaviour caused
by #19280. This causes a panic on running the default doctor checks
because the panic introduced by #19280 assumes that the only way
opts.StdOut and opts.Stderr can be set in RunOpts is deliberately.
Unfortunately, when running a git.Command the provided RunOpts can be
set, therefore if you share a common set of RunOpts these two values can
be set by the previous commands.

This PR stops using common RunOpts for the commands in that doctor check
but secondly stops RunCommand variants from changing the provided
RunOpts.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-11-14 10:58:32 +08:00
..
authorizedkeys.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
breaking.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
checkOldArchives.go Use ctx instead of db.DefaultContext in some packages(routers/services/modules) (#19163) 2022-03-22 16:22:54 +01:00
dbconsistency.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
dbversion.go Propagate context and ensure git commands run in request context (#17868) 2022-01-19 23:26:57 +00:00
doctor.go Fix git.Init for doctor sub-command (#20782) 2022-08-14 00:33:18 +08:00
fix16961.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
fix16961_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
heads.go Prevent panic in doctor command when running default checks (#21791) (#21807) 2022-11-14 10:58:32 +08:00
mergebase.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
misc.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
paths.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
storage.go Propagate context and ensure git commands run in request context (#17868) 2022-01-19 23:26:57 +00:00
usertype.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00