thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions
forgejo/routers/api/v1/repo
History
Earl Warren b173a0ccee
[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments 
Refs: https://codeberg.org/forgejo/forgejo/issues/2109
(cherry picked from commit 8b4ba3dce7)
(cherry picked from commit 196edea0f9)

[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments (squash) do not implicitly create a review

If a comment already exists in a review, the comment is added. If it
is the first comment added to a review, it will implicitly create a
new review instead of adding to the existing one.

The pull_service.CreateCodeComment function is responsibe for this
behavior and it will defer to createCodeComment once the review is
determined, either because it was found or because it was created.

Rename createCodeComment into CreateCodeCommentKnownReviewID to expose
it and change the API endpoint to use it instead. Since the review is
provided by the user and verified to exist already, there is no need
for the logic implemented by CreateCodeComment.

The tests are modified to remove the initial comment from the fixture
because it was creating the false positive. I was verified to fail
without this fix.

(cherry picked from commit 6a555996dc)
2024-01-22 18:13:42 +00:00
..
action.go Refactor secrets modification logic (#26873) 2023-09-05 15:21:02 +00:00
avatar.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
blob.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
branch.go Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
collaborators.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
commits.go Filter get single commit (#24613) 2023-05-10 09:34:07 +08:00
file.go Updates to the API for archived repos (#27149) 2023-09-21 23:43:29 +00:00
flags.go [FEAT] API support for repository flags 2024-01-22 18:13:42 +00:00
fork.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
git_hook.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
git_ref.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hook.go Use db.Find instead of writing methods for every object (#28084) 2023-11-24 03:49:41 +00:00
hook_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
issue.go [FEAT] allow setting the update date on issues and comments 2024-01-22 13:41:21 +00:00
issue_attachment.go [FEAT] allow setting the update date on issues and comments 2024-01-22 13:41:21 +00:00
issue_comment.go [FEAT] allow setting the update date on issues and comments 2024-01-22 13:41:21 +00:00
issue_comment_attachment.go [FEAT] allow setting the update date on issues and comments 2024-01-22 13:41:21 +00:00
issue_dependency.go Fix issue dependencies (#27736) 2024-01-12 16:49:02 +00:00
issue_label.go [FEAT] allow setting the update date on issues and comments 2024-01-22 13:41:21 +00:00
issue_pin.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_reaction.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
issue_stopwatch.go Final round of db.DefaultContext refactor (#27587) 2023-10-14 08:37:24 +00:00
issue_subscription.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_tracked_time.go Final round of db.DefaultContext refactor (#27587) 2023-10-14 08:37:24 +00:00
key.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
label.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
language.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
migrate.go Remove unnecessary parameter (#27671) 2023-10-18 15:03:10 +00:00
milestone.go Second part of refactor db.Find (#28194) 2023-12-11 16:56:48 +08:00
mirror.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
notes.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
patch.go Updates to the API for archived repos (#27149) 2023-09-21 23:43:29 +00:00
pull.go Retarget depending pulls when the parent branch is deleted (#28686) 2024-01-17 01:44:56 +01:00
pull_review.go [GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments 2024-01-22 18:13:42 +00:00
release.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
release_attachment.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
release_tags.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
repo.go Add support for sha256 repositories (#23894) 2024-01-19 17:05:02 +01:00
repo_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
runners.go Add get actions runner registration token for API routes, repo, org, user and global level (#27144) 2023-12-27 07:57:54 +00:00
star.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
status.go Fix GetCommitStatuses (#28787) 2024-01-15 14:07:32 +00:00
subscriber.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
tag.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
teams.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
topic.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
transfer.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
tree.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
wiki.go Updates to the API for archived repos (#27149) 2023-09-21 23:43:29 +00:00