thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions
forgejo/services/migrations
History
Giteabot 693c2b4f15
Fix migration panic due to an empty review comment diff (#28334) (#28362) 
Backport #28334 by @lng2020

Fix #28328
```
func (p *PullRequestComment) GetDiffHunk() string {
	if p == nil || p.DiffHunk == nil {
		return ""
	}
	return *p.DiffHunk
}
```
This function in the package `go-github` may return an empty diff. When
it's empty, the following code will panic because it access `ss[1]`

ec1feedbf5/services/migrations/gitea_uploader.go (L861-L867)

ec1feedbf5/modules/git/diff.go (L97-L101)

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
(cherry picked from commit 8b590de186)
2023-12-08 13:41:16 +01:00
..
testdata/gitlab [GITEA] Avoid conflicts of issue and PR numbers in GitLab migration (#1790) 2023-12-01 19:17:46 +00:00
codebase.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
codebase_test.go
common.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
dump.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
error.go Update github.com/google/go-github to v53 (#25157) 2023-06-09 19:42:51 +00:00
forgejo_downloader.go [FEAT] add Forgejo Git Service (squash) register a Forgejo factory 2023-12-06 12:40:06 +01:00
git.go
gitbucket.go Rewrite logger system (#24726) 2023-05-21 22:35:11 +00:00
gitea_downloader.go Fix DownloadFunc when migrating releases (#27887) (#27890) 2023-11-03 08:29:30 +00:00
gitea_downloader_test.go
gitea_uploader.go Fix migration panic due to an empty review comment diff (#28334) (#28362) 2023-12-08 13:41:16 +01:00
gitea_uploader_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
github.go Fix panic when migrating a repo from GitHub with issues (#25246) 2023-06-14 14:12:39 +08:00
github_test.go
gitlab.go [GITEA] Avoid conflicts of issue and PR numbers in GitLab migration (#1790) 2023-12-01 19:17:46 +00:00
gitlab_test.go [GITEA] Avoid conflicts of issue and PR numbers in GitLab migration (#1790) 2023-12-01 19:17:46 +00:00
gogs.go Rewrite logger system (#24726) 2023-05-21 22:35:11 +00:00
gogs_test.go
http_client.go
main_test.go
migrate.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
migrate_test.go
onedev.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
onedev_test.go
restore.go
update.go Another round of db.DefaultContext refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00