thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions
forgejo/modules/git
History
Twenty Panda 5561e80b04 fix(hook): ignore unknown push options instead of failing 
If a repository has

git config --add push.pushOption submit=".sourcehut/*.yml"

it failed when pushed because of the unknown submit push
option. It will be ignored instead.

Filtering out the push options is done in an earlier stage, when the
hook command runs, before it submits the options map to the private
endpoint.

* move all the push options logic to modules/git/pushoptions
* add 100% test coverage for modules/git/pushoptions

Test coverage for the code paths from which code was moved to the
modules/git/pushoptions package:

* cmd/hook.go:runHookPreReceive
* routers/private/hook_pre_receive.go:validatePushOptions
  tests/integration/git_push_test.go:TestOptionsGitPush runs through
  both. The test verifying the option is rejected was removed and, if
  added again, will fail because the option is now ignored instead of
  being rejected.

* cmd/hook.go:runHookProcReceive
* services/agit/agit.go:ProcReceive
  tests/integration/git_test.go: doCreateAgitFlowPull runs through
  both. It uses variations of AGit related push options.

* cmd/hook.go:runHookPostReceive
* routers/private/hook_post_receive.go:HookPostReceive
  tests/integration/git_test.go:doPushCreate called by TestGit/HTTP/sha1/PushCreate
  runs through both.
  Note that although it provides coverage for this code path it does not use push options.

Fixes: https://codeberg.org/forgejo/forgejo/issues/3651
2024-07-02 21:39:01 +02:00
..
foreachref Use refname:strip-2 instead of refname:short when syncing tags (#28797) 2024-01-16 08:13:07 +01:00
internal
pipeline Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
pushoptions fix(hook): ignore unknown push options instead of failing 2024-07-02 21:39:01 +02:00
tests/repos [PERFORMANCE] git check-attr on bare repo if supported 2024-03-28 10:52:51 +01:00
url
batch_reader.go Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
blame.go Add io.Closer guidelines (#29387) 2024-02-26 22:30:27 +01:00
blame_sha256_test.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
blame_test.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
blob.go
blob_gogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
blob_nogogit.go Do not double close reader (#29354) 2024-02-26 22:30:26 +01:00
blob_test.go
command.go Support repo code search without setting up an indexer (#29998) 2024-03-28 05:16:51 +00:00
command_race_test.go
command_test.go
commit.go Fix commit file status parser (#30602) 2024-04-21 16:28:16 +02:00
commit_convert_gogit.go Include encoding in signature payload (#30174) 2024-04-07 15:40:31 +02:00
commit_info.go
commit_info_gogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
commit_info_nogogit.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-05-05 08:38:16 +01:00
commit_info_test.go
commit_reader.go Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
commit_sha256_test.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
commit_test.go Include encoding in signature payload (#30174) 2024-04-07 15:40:31 +02:00
diff.go
diff_test.go [CHORE] Remove println 2024-04-12 13:36:31 +02:00
error.go Add merge style fast-forward-only (#28954) 2024-02-14 17:19:19 +01:00
git.go Enable unparam linter (#31277) 2024-06-16 13:42:58 +02:00
git_test.go
grep.go feat: wiki search using git-grep 2024-05-20 13:48:50 +00:00
grep_test.go feat: wiki search using git-grep 2024-05-20 13:48:50 +00:00
hook.go
last_commit_cache.go [GITEA] Drop sha256-simd in favor of stdlib 2024-02-05 16:09:40 +01:00
last_commit_cache_gogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
last_commit_cache_nogogit.go
log_name_status.go [CLEANUP] make golangci-lint@v1.56.1 happy 2024-02-15 16:19:36 +01:00
notes.go
notes_gogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
notes_nogogit.go
notes_test.go
object_format.go Enable unparam linter (#31277) 2024-06-16 13:42:58 +02:00
object_id.go chore: fix typos identified by mispell 2024-05-25 09:43:50 +02:00
object_id_gogit.go Add support for sha256 repositories (#23894) 2024-01-19 17:05:02 +01:00
object_id_test.go fix: hook post-receive for sha256 repos 2024-05-15 16:43:16 +02:00
object_signature.go Rename CommitGPGSignature to ObjectSignature 2024-03-26 08:09:36 +00:00
parse_gogit.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-05-05 08:38:16 +01:00
parse_gogit_test.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-05-05 08:38:16 +01:00
parse_nogogit.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-05-05 08:38:16 +01:00
parse_nogogit_test.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-05-05 08:38:16 +01:00
README.md
ref.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
ref_test.go
remote.go
repo.go Make "sync branch" also sync object format and add tests (#30878) 2024-05-12 20:03:10 +02:00
repo_archive.go Fix archive creating LFS hooks and breaking pull requests (#28848) 2024-01-19 05:49:18 +00:00
repo_attribute.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
repo_attribute_test.go Fix spelling mistakes caught by golangci-lint 2024-04-11 17:16:26 +02:00
repo_base.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
repo_base_gogit.go Add io.Closer guidelines (#29387) 2024-02-26 22:30:27 +01:00
repo_base_nogogit.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
repo_blame.go
repo_blob.go Improve ObjectFormat interface (#28496) 2023-12-19 07:20:47 +00:00
repo_blob_gogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
repo_blob_nogogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
repo_blob_test.go Improve ObjectFormat interface (#28496) 2023-12-19 07:20:47 +00:00
repo_branch.go Move get/set default branch from git package to gitrepo package to hide repopath (#29126) 2024-03-11 23:36:59 +07:00
repo_branch_gogit.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
repo_branch_nogogit.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
repo_branch_test.go
repo_commit.go Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
repo_commit_gogit.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
repo_commit_nogogit.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
repo_commit_test.go
repo_commitgraph.go
repo_commitgraph_gogit.go Update go dependencies and fix go-git (#28893) 2024-01-23 05:40:00 +00:00
repo_compare.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
repo_compare_test.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
repo_gpg.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
repo_hook.go
repo_index.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
repo_language_stats.go Convert linguist attribute handling to optional.Option 2024-02-26 12:52:59 +01:00
repo_language_stats_gogit.go Correctly support linguist-documentation=false 2024-02-26 14:18:33 +01:00
repo_language_stats_nogogit.go [PERFORMANCE] git check-attr on bare repo if supported 2024-03-28 10:52:51 +01:00
repo_language_stats_test.go
repo_object.go Improve ObjectFormat interface (#28496) 2023-12-19 07:20:47 +00:00
repo_ref.go Fixes git references wrongly transmitted to the action run 2024-06-30 06:17:40 +02:00
repo_ref_gogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
repo_ref_nogogit.go Improve ObjectFormat interface (#28496) 2023-12-19 07:20:47 +00:00
repo_ref_test.go
repo_stats.go Fix some pending problems (#29985) 2024-03-26 19:04:26 +01:00
repo_stats_test.go
repo_tag.go Rename CommitGPGSignature to ObjectSignature 2024-03-26 08:09:36 +00:00
repo_tag_gogit.go Improve ObjectFormat interface (#28496) 2023-12-19 07:20:47 +00:00
repo_tag_nogogit.go Discard unread data of git cat-file (#29297) 2024-02-26 22:30:25 +01:00
repo_tag_test.go Rename CommitGPGSignature to ObjectSignature 2024-03-26 08:09:36 +00:00
repo_test.go
repo_tree.go Improve ObjectFormat interface (#28496) 2023-12-19 07:20:47 +00:00
repo_tree_gogit.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
repo_tree_nogogit.go Lazy load object format with command line and don't do it in OpenRepository (#29712) 2024-03-20 08:46:28 +01:00
signature.go [gitea] Refactor parseSignatureFromCommitLine (#29054) 2024-02-10 10:53:43 +01:00
signature_gogit.go [gitea] Refactor parseSignatureFromCommitLine (#29054) 2024-02-10 10:53:43 +01:00
signature_nogogit.go [gitea] Refactor parseSignatureFromCommitLine (#29054) 2024-02-10 10:53:43 +01:00
signature_test.go [gitea] Refactor parseSignatureFromCommitLine (#29054) 2024-02-10 10:53:43 +01:00
submodule.go Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
submodule_test.go
tag.go Count downloads for tag archives 2024-04-08 12:51:27 +02:00
tag_test.go Rename CommitGPGSignature to ObjectSignature 2024-03-26 08:09:36 +00:00
tree.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
tree_blob.go [GITEA] Find README.md for user profiles case insensitively 2024-02-05 16:09:42 +01:00
tree_blob_gogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
tree_blob_nogogit.go
tree_entry.go [FEAT] Show follow symlink button 2024-03-02 17:58:09 +01:00
tree_entry_gogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
tree_entry_mode.go
tree_entry_nogogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
tree_entry_test.go
tree_gogit.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
tree_nogogit.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-05-05 08:38:16 +01:00
tree_test.go Discard unread data of git cat-file (#29297) 2024-02-26 22:30:25 +01:00
utils.go Refactor sha1 and time-limited code (#31023) 2024-05-26 18:43:30 +02:00
utils_test.go Refactor sha1 and time-limited code (#31023) 2024-05-26 18:43:30 +02:00

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.