sillyguodong e8e871b44e Fix cannot reopen after pushing commits to a closed PR (#23189) (#23324) ... Backport: #23189 Close: #22784 1. On GH, we can reopen a PR which was closed before after pushing commits. After reopening PR, we can see the commits that were pushed after closing PR in the time line. So the case of [issue](https://github.com/go-gitea/gitea/issues/22784) is a bug which needs to be fixed. 2. After closing a PR and pushing commits, `headBranchSha` is not equal to `sha`(which is the last commit ID string of reference). If the judgement exists, the button of reopen will not display. So, skip the judgement if the status of PR is closed.  3. Even if PR is already close, we should still insert comment record into DB when we push commits. So we should still call function `CreatePushPullComment()`. 067b0c2664/services/pull/pull.go (L260-L282) So, I add a switch(`includeClosed`) to the `GetUnmergedPullRequestsByHeadInfo` func to control whether the status of PR must be open. In this case, by setting `includeClosed` to `true`, we can query the closed PR.  4. In the loop of comments, I use the`latestCloseCommentID` variable to record the last occurrence of the close comment. In the go template, if the status of PR is closed, the comments whose type is `CommentTypePullRequestPush(29)` after `latestCloseCommentID` won't be rendered.  e.g. 1). The initial status of the PR is opened.  2). Then I click the button of `Close`. PR is closed now.  3). I try to push a commit to this PR, even though its current status is closed.  But in comments list, this commit do not display.This is as expected ：）  4). Click the `Reopen` button, the commit which is pushed after closing PR display now.  --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		2023-03-07 18:47:23 +08:00
..
actions	Avoid too long names for actions (#23162) (#23190)	2023-02-28 13:42:40 +01:00
activities	Rename repo.GetOwner to repo.LoadOwner (#22967)	2023-02-18 20:11:03 +08:00
admin	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
asymkey	Refactor the setting to make unit test easier (#22405)	2023-02-20 00:12:01 +08:00
auth	Add scopes to API to create token and display them (#22989)	2023-02-20 15:28:44 -06:00
avatars	Avoid warning for system setting when start up (#23054) (#23116)	2023-02-24 16:46:11 -05:00
db	Fix db.Find bug (#23115) (#23119)	2023-02-24 14:05:36 +00:00
dbfs	Refactor the setting to make unit test easier (#22405)	2023-02-20 00:12:01 +08:00
fixtures	Use correct README link to render the README (#23152) (#23264)	2023-03-04 00:38:11 -05:00
git	Rename repo.GetOwner to repo.LoadOwner (#22967)	2023-02-18 20:11:03 +08:00
issues	Fix cannot reopen after pushing commits to a closed PR (#23189) (#23324)	2023-03-07 18:47:23 +08:00
migrations	Add comment marking the end of database migrations in 1.19.0 (#22975)	2023-02-20 10:30:36 +08:00
organization	Rename GetUnits to LoadUnits (#22970)	2023-02-19 16:31:39 +08:00
packages	Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986)	2023-02-06 12:09:18 -06:00
perm	Rename repo.GetOwner to repo.LoadOwner (#22967)	2023-02-18 20:11:03 +08:00
project	Preview images for Issue cards in Project Board view (#22112)	2023-02-11 16:12:41 +08:00
pull	refactor some functions to support ctx as first parameter (#21878)	2022-12-03 10:48:26 +08:00
repo	Rename repo.GetOwner to repo.LoadOwner (#22967)	2023-02-18 20:11:03 +08:00
secret	Secrets storage with SecretKey encrypted (#22142)	2022-12-20 17:07:13 +08:00
system	Avoid warning for system setting when start up (#23054) (#23116)	2023-02-24 16:46:11 -05:00
unit	Repositories: by default disable all units except code and pulls on forks (#22541)	2023-02-04 14:48:38 +08:00
unittest	Avoid warning for system setting when start up (#23054) (#23116)	2023-02-24 16:46:11 -05:00
user	Avoid warning for system setting when start up (#23054) (#23116)	2023-02-24 16:46:11 -05:00
webhook	Support system hook API (#14537)	2023-01-28 19:12:10 +01:00
error.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
fixture_generation.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
fixture_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
main_test.go	Refactor the setting to make unit test easier (#22405)	2023-02-20 00:12:01 +08:00
migrate.go	Check primary keys for all tables and drop ForeignReference (#21721)	2022-12-23 19:35:43 +08:00
migrate_test.go	Check primary keys for all tables and drop ForeignReference (#21721)	2022-12-23 19:35:43 +08:00
org.go	refactor some functions to support ctx as first parameter (#21878)	2022-12-03 10:48:26 +08:00
org_team.go	Supports wildcard protected branch (#20825)	2023-01-16 16:00:22 +08:00
org_team_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
org_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
repo.go	Avoid warning for system setting when start up (#23054) (#23116)	2023-02-24 16:46:11 -05:00
repo_collaboration.go	refactor some functions to support ctx as first parameter (#21878)	2022-12-03 10:48:26 +08:00
repo_collaboration_test.go	Rename repo.GetOwner to repo.LoadOwner (#22967)	2023-02-18 20:11:03 +08:00
repo_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
repo_transfer.go	Always reuse transaction (#22362)	2023-01-08 09:34:58 +08:00
repo_transfer_test.go	Rename almost all Ctx functions (#22071)	2022-12-10 10:46:31 +08:00