thepaperpilot/forgejo
1
0
Fork 0
Code Issues Pull requests Releases Activity Actions 4
forgejo/routers/web
History
Giteabot f6919e3e53
Respect original content when creating secrets (#24745) (#24746) 
Backport #24745 by @wolfogre

Fix #24721.

Follow what GitHub does:
- Don't trim spaces for secrets.
- Newline should be `\n` instead of `\r\n`.

Did some tests with:

```yaml
name: secrets
on: push
jobs:
  show_secrets:
    runs-on: ubuntu-latest
    steps:
      - name: Dump secrets context
        run: echo '${{ toJSON(secrets) }}' | base64
```

`AAAAAA`:
```text
   AAAAAA
AAAAAA

```
`BBBBBB`:
```text

BBBBBB
BBBBBB
```

On GitHub:

<img width="675" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0ec60652-c2a3-47bb-9f9d-7e81665355a8">

On Gitea (before):

<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/cce818bf-5edc-4656-86e1-2c81c304cdb2">

On Gitea (after):

<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0b3b15af-4d48-4bab-a334-4738a1b0eb4a">

Co-authored-by: Jason Song <i@wolfogre.com>
(cherry picked from commit e4f200e616)
2023-05-23 07:42:33 +02:00
..
admin [BRANDING] alias {FORGEJO,GITEA}_{CUSTOM,WORK_DIR} 2023-05-10 11:05:22 +02:00
auth Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (#24035) (#24333) 2023-04-25 15:25:08 -04:00
events Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
explore Add ONLY_SHOW_RELEVANT_REPOS back, fix explore page bug, make code more strict (#23766) (#23791) 2023-03-30 09:09:22 -05:00
feed User/Org Feed render description as per web (#23887) (#23906) 2023-04-04 00:44:50 -04:00
healthcheck Refactor setting.Database.UseXXX to methods (#23354) (#23356) 2023-03-07 20:11:44 +08:00
misc [API] Forgejo API /api/forgejo/v1 2023-05-10 09:20:14 +02:00
org Fix close org projects (#24588) (#24591) 2023-05-08 20:50:27 +02:00
repo fix: release page for empty or non-existing target (#24659) 2023-05-16 07:42:22 +02:00
shared Respect original content when creating secrets (#24745) (#24746) 2023-05-23 07:42:33 +02:00
user Only delete secrets belonging to its owner (#24284) (#24286) 2023-04-23 16:36:20 +02:00
auth.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
auth_windows.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
base.go Set X-Gitea-Debug header once (#23361) (#23381) 2023-03-09 06:33:05 +08:00
goget.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
home.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
metrics.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
nodeinfo.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
swagger_json.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
web.go [BRANDING] define the forgejo webhook type 2023-05-10 11:05:22 +02:00
webfinger.go Use User.ID instead of User.Name in ActivityPub API for Person IRI (#23823) (#23905) 2023-04-03 22:41:57 -05:00