profectus/Profectus
Template
1
0
Fork 4
Code Issues 38 Pull requests 6 Projects 2 Releases Packages Wiki Activity Actions

Add automated test to check for any eslint/prettier issues that need to be fixed #63

New issue
Closed
opened 2024-02-14 20:17:25 +00:00 by thepaperpilot · 0 comments
thepaperpilot commented 2024-02-14 20:17:25 +00:00
Collaborator
Copy link

Would help keep the code style more consistent, since not everyone has the "run prettier on save" setting on their IDE.

Alongside this, proper contribution guidelines should probably be written somewhere that mentions running prettier on any changed files is expected and required before a PR gets merged. It could also mention bug fixes require a regression test to be written that fails without the fix and passes with the fix.

Would help keep the code style more consistent, since not everyone has the "run prettier on save" setting on their IDE. Alongside this, proper contribution guidelines should probably be written somewhere that mentions running prettier on any changed files is expected and required before a PR gets merged. It could also mention bug fixes require a regression test to be written that fails without the fix and passes with the fix.
thepaperpilot added this to the Automated Testing project 2024-02-14 20:17:31 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/ure-rewrite
pages
ducdat0507/patch-1
feature/requirements-refactor
jakub791/main
fix/lazy-proxy-typing
gh-pages
No results found.
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Automated Testing
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: profectus/Profectus#63
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?