profectus/Profectus
Template
1
0
Fork 4
Code Issues 38 Pull requests 6 Projects 2 Releases Packages Wiki Activity Actions

Add eslint workflow action and CONTRIBUTING.md that says to lint first #66

Merged
thepaperpilot merged 6 commits from thepaperpilot/Profectus:feat/enforce-eslint into main 2024-03-06 04:45:20 +00:00
Conversation 1 Commits 6 Files changed 11 +50 -9
thepaperpilot commented 2024-02-18 02:16:58 +00:00
Collaborator
Copy link
No description provided.
thepaperpilot added 1 commit 2024-02-18 02:16:58 +00:00
Add eslint workflow action and CONTRIBUTING.md that says to lint first
Some checks failed
Run Tests / test (pull_request) Failing after 2m2s
Details
143b0773e7
thepaperpilot added 1 commit 2024-02-18 02:17:04 +00:00
Merge branch 'main' into feat/enforce-eslint
Some checks failed
Run Tests / test (pull_request) Failing after 2m1s
Details
fa2d7cb53a
thepaperpilot commented 2024-02-18 02:18:16 +00:00
Author
Collaborator
Copy link

Fixes #63

Fixes #63
escapee reviewed 2024-02-21 01:38:28 +00:00
CONTRIBUTING.md Outdated
@ -0,0 +8,4 @@
## Contributing
Make sure to open your PR on Incremental Social - the GitHub repo is just a mirror!
escapee commented 2024-02-21 01:35:02 +00:00
Collaborator
Copy link

I think this should have a link to the Incremental Social repo in this line, as not everyone will know what/where that is.

I think this should have a link to the Incremental Social repo in this line, as not everyone will know what/where that is.
CONTRIBUTING.md
@ -0,0 +18,4 @@
Ensure that your changes pass all existing tests and, if applicable, add new tests to cover the changes you've made. Run `npm run test` to run all the tests.
## Code Style
escapee commented 2024-02-21 01:37:33 +00:00
Collaborator
Copy link

Is this supposed to be a subcategory of Contributing (###) or a separate category (##)?

Is this supposed to be a subcategory of Contributing (###) or a separate category (##)?
escapee marked this conversation as resolved
CONTRIBUTING.md Outdated
@ -0,0 +22,4 @@
We use ESLint and Prettier to enforce consistent code style throughout the project. Before submitting a PR, run `npm run lint:fix` to automatically fix any linting issues.
## Issue Reporting
escapee commented 2024-02-21 01:36:52 +00:00
Collaborator
Copy link

Feel like Issue Reporting should go before Contributing, since it's likely more relevant to the average use case

Feel like Issue Reporting should go before Contributing, since it's likely more relevant to the average use case
thepaperpilot added 1 commit 2024-02-21 04:17:07 +00:00
PR Feedback
Some checks failed
Run Tests / test (pull_request) Failing after 2m6s
Details
64fad5c74a
thepaperpilot added 2 commits 2024-02-21 04:38:55 +00:00
Lint
All checks were successful
Run Tests / test (pull_request) Successful in 2m12s
Details
f7a8fbbb11
thepaperpilot added a new dependency 2024-03-04 01:26:03 +00:00
#73 Allow null and undefined values in persistent refs
thepaperpilot added 1 commit 2024-03-04 01:26:31 +00:00
Merge branch 'main' into feat/enforce-eslint
All checks were successful
Run Tests / test (pull_request) Successful in 2m3s
Details
df9ba59a1a
escapee approved these changes 2024-03-06 01:05:05 +00:00
thepaperpilot merged commit b2d7a9ea1d into main 2024-03-06 04:45:20 +00:00
thepaperpilot deleted branch feat/enforce-eslint 2024-03-06 04:45:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
escapee
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#73 Allow null and undefined values in persistent refs}
profectus/Profectus
Reference: profectus/Profectus#66
No description provided.
Delete branch "thepaperpilot/Profectus:feat/enforce-eslint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?