Add regression test for modifier.getFormula respecting enabled #58

Merged
thepaperpilot merged 5 commits from thepaperpilot/Profectus:feat/getformula-regression-test into main 2024-02-21 01:25:53 +00:00
Collaborator
No description provided.
thepaperpilot added 1 commit 2024-02-13 12:50:38 +00:00
Add regression test for modifier.getFormula respecting enabled
All checks were successful
Run Tests / test (pull_request) Successful in 2m8s
1b30560c40
thepaperpilot added 1 commit 2024-02-18 13:54:47 +00:00
Merge branch 'main' into feat/getformula-regression-test
All checks were successful
Run Tests / test (pull_request) Successful in 2m7s
e622cc1c15
escapee requested changes 2024-02-19 14:52:27 +00:00
@ -202,0 +209,4 @@
value.value
);
enabled.value = true;
expect(modifier.getFormula(Formula.variable(value)).evaluate()).not.compare_tolerance(
Collaborator

For this test, we should be making the formula once, then re-using it when the conditions change.
Should be more like

const formula = modifier.getFormula()
expect formula.evaluate() == value
enabled = true
expect formula.evaluate() != value
For this test, we should be making the formula once, then re-using it when the conditions change. Should be more like ``` const formula = modifier.getFormula() expect formula.evaluate() == value enabled = true expect formula.evaluate() != value ```
thepaperpilot marked this conversation as resolved
thepaperpilot added 1 commit 2024-02-20 14:33:04 +00:00
Made modifier typing a lot less nasty
All checks were successful
Run Tests / test (pull_request) Successful in 2m15s
4f7a5abdc9
thepaperpilot added 1 commit 2024-02-20 15:11:02 +00:00
PR feedback
All checks were successful
Run Tests / test (pull_request) Successful in 2m4s
22581ba2a1
thepaperpilot requested review from escapee 2024-02-20 15:14:01 +00:00
thepaperpilot added 1 commit 2024-02-21 01:23:20 +00:00
Remove unused imports
All checks were successful
Run Tests / test (pull_request) Successful in 2m6s
a0fb29d6a1
escapee approved these changes 2024-02-21 01:23:46 +00:00
thepaperpilot merged commit a39e65852d into main 2024-02-21 01:25:53 +00:00
thepaperpilot deleted branch feat/getformula-regression-test 2024-02-21 01:25:53 +00:00
Sign in to join this conversation.
No description provided.