profectus/Profectus
Template
1
0
Fork 5
Code Issues 32 Pull requests 2 Projects 2 Releases 1 Packages Wiki Activity Actions

Add regression test for modifier.getFormula respecting enabled #58

Merged
thepaperpilot merged 5 commits from thepaperpilot/Profectus:feat/getformula-regression-test into main 2024-02-21 01:25:53 +00:00
Conversation 2 Commits 5 Files changed 3 +3 -6
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 22581ba2a1 - Show all commits

9
tests/game/modifiers.test.ts
View file

@ -205,13 +205,10 @@ describe("Sequential Modifiers", () => {
const modifier = createSequentialModifier(() => [
createMultiplicativeModifier(() => ({ multiplier: 5, enabled }))
]);
expect(modifier.getFormula(Formula.variable(value)).evaluate()).compare_tolerance(
value.value
);
const formula = modifier.getFormula(Formula.variable(value));
expect(formula.evaluate()).compare_tolerance(value.value);
enabled.value = true;
expect(modifier.getFormula(Formula.variable(value)).evaluate()).not.compare_tolerance(
value.value
);
expect(formula.evaluate()).not.compare_tolerance(value.value);
});
thepaperpilot marked this conversation as resolved
escapee commented 2024-02-19 05:39:43 +00:00
Review
Copy link

For this test, we should be making the formula once, then re-using it when the conditions change.
Should be more like

const formula = modifier.getFormula()
expect formula.evaluate() == value
enabled = true
expect formula.evaluate() != value
For this test, we should be making the formula once, then re-using it when the conditions change. Should be more like ``` const formula = modifier.getFormula() expect formula.evaluate() == value enabled = true expect formula.evaluate() != value ```
});