profectus/Profectus

Template

Fork 4

Rewriting board #79

Closed

thepaperpilot wants to merge 0 commits from thepaperpilot/Profectus:feat/board-rewrite into main

thepaperpilot commented

2024-03-12 20:18:15 +00:00

Collaborator

#72
profectus/profectus-docs#13

#72 https://code.incremental.social/profectus/profectus-docs/pulls/13

thepaperpilot added 12 commits 2024-03-12 20:18:15 +00:00

WIP on rewriting board

Run Tests / test (pull_request) Failing after 57s

Details

424bde0cdd

Add support for rendering VueFeatures in boards

Run Tests / test (pull_request) Failing after 47s

Details

1acfde134b

Add cnodes

Run Tests / test (pull_request) Failing after 46s

Details

f0e831ee8f

Use z-index to avoid changing render order aca56f6af6

Perf optimization 3fd8375031

Fix upgrade purchasing on drag

Run Tests / test (pull_request) Failing after 48s

Details

17b878e3be

Document boards 68b1401c2a

Add some tests for boards ad421ac759

Move board to src/game 2cfa450d96

Move common board node CSS to class 0e7ca27e3b

Revert changes in /data. Check the board-example branch for them instead 1b267edc32

Add link to docs in setupDraggableNode docstring

Run Tests / test (pull_request) Successful in 2m2s

Details

1c7824b550

escapee approved these changes 2024-11-26 22:08:32 +00:00

escapee left a comment

Collaborator

The updates to dependencies that have happened since this was made seems to have broken things a bit, primarily on vscode's end - actually running this stuff works out fine once you insert /* @vue-ignore */ into the CircleProgress and SquareProgress sample components. Since those issues look to be far more related to dependencies being out-of-whack after 9 months of me not paying attention to this, I'm approving this PR, with the intent that I'll help figure out another dependency bump before we do the next release.

Currently looks like these'll take a good chunk of manual work to build up whatever utilities around boards you're looking for, but that can be improved as people use them more - it's a nice basic setup to extend into whatever design might be needed. The updates to dependencies that have happened since this was made seems to have broken things a bit, primarily on vscode's end - actually running this stuff works out fine once you insert `/* @vue-ignore */` into the CircleProgress and SquareProgress sample components. Since those issues look to be far more related to dependencies being out-of-whack after 9 months of me not paying attention to this, I'm approving this PR, with the intent that I'll help figure out another dependency bump before we do the next release.

thepaperpilot commented

2024-11-27 20:59:53 +00:00

Author

Collaborator

I think this PR still has the missing fork information bug that's been fixed on the newer PRs, so if I have to push to this branch again anyways (to reset the fork information), I think I'll merge the other update deps PR into this one, so its all up to date. The feature rewrite was also based off the update deps PR so doing it this way will make that one easier to resolve as well.

thepaperpilot added 35 commits 2024-11-29 13:53:07 +00:00

Update fontsource dependencies 90300ce848

Update vite dependencies 8a9e106157

Bump some minor dependencies ae45f9bc2f

Switch from CJS to ESM 673f7790c7

Removed dynamic imports 6ba25f9abd

WIP on rewriting board 1cbe97251c

Add support for rendering VueFeatures in boards c64ac82a25

Add cnodes a75c8d81f8

Use z-index to avoid changing render order 6a17bbc29c

Perf optimization 5b33a0fceb

Fix upgrade purchasing on drag 8745304631