profectus/Profectus

Template

Fork 4

WIP: Feature Rewrite #87

Draft

thepaperpilot wants to merge 35 commits from feat/ure-rewrite into main

thepaperpilot commented

2024-11-19 14:35:40 +00:00

Collaborator

Removed jsx() and JSXFunction. You can now use JSX.Element like any other Computable value
joinJSX now always requires a joiner. Just pass the array of elements or wrap them in <> and </> if there's no joiner
Removed coerceComponent, computeComponent, and computeOptionalComponent; just use the render function now
It's recommended to now do <MyComponent /> instead of <component :is="myComponent" />
All features no longer take the options as a type parameter, and all generic forms have been removed as a result
Fixed forceHideGoBack not being respected
Removed deepUnref as now things don't get unreffed before being passed into vue components by default
Moved MarkNode to new wrapper, and removed existing mark properties
Moved Tooltip to new wrapper, and made it take an options function instead of raw object
VueFeature component now wraps all vue features, and applies styling, classes, and visibility in the wrapping div. It also adds the Node component so features don't need to
mergeAdjacent now works with grids (perhaps should've used scss to reduce the amount of css this took)
CoercableComponent renamed to Renderable since it should be used with render
Replaced isCoercableComponent with isJSXElement
Replaced Computable and ProcessedComputable with the vue built-ins MaybeRefOrGetter and MaybeRef
convertComputable renamed to processGetter
Also removed GetComputableTypeWithDefault and GetComputableType, which can similarly be replaced
dontMerge is now a property on rows and columns rather than an undocumented css class you'd have to include on every feature within the row or column
Fixed saves manager not being imported in addiction warning component
Created vueFeatureMixin for simplifying the vue specific parts of a feature. Passes the component's properties in explicitly and directly from the feature itself
All features should now return an object that includes props typed to omit the options object and satisfies the feature. This will ensure type correctness and pass-through custom properties. (see existing features for more thorough examples of changes)
Replaced decorators with mixins, which won't require casting. Bonus amount decorators converted into generic bonus amount mixin. Removed effect decorator
All render functions now return JSX.Element. The JSX variants (e.g. renderJSX) (except joinJSX) have been removed
Moved all features that use the clickable component into the clickable folder
Removed small property from clickable, since its a single css rule (min-height: unset) (you could add a small css class and pass small to any vue feature's classes property, though)
Upgrades now use the clickable component
Added ConversionType symbol
Removed setDefault, just use ??=
Added isType function that uses a type symbol to check
General cleanup

- Removed `jsx()` and `JSXFunction`. You can now use `JSX.Element` like any other `Computable` value - `joinJSX` now always requires a joiner. Just pass the array of elements or wrap them in `<>` and `</>` if there's no joiner - Removed `coerceComponent`, `computeComponent`, and `computeOptionalComponent`; just use the `render` function now - It's recommended to now do `<MyComponent />` instead of `<component :is="myComponent" />` - All features no longer take the options as a type parameter, and all generic forms have been removed as a result - Fixed `forceHideGoBack` not being respected - Removed `deepUnref` as now things don't get unreffed before being passed into vue components by default - Moved MarkNode to new wrapper, and removed existing `mark` properties - Moved Tooltip to new wrapper, and made it take an options function instead of raw object - VueFeature component now wraps all vue features, and applies styling, classes, and visibility in the wrapping div. It also adds the Node component so features don't need to - `mergeAdjacent` now works with grids (perhaps should've used scss to reduce the amount of css this took) - `CoercableComponent` renamed to `Renderable` since it should be used with `render` - Replaced `isCoercableComponent` with `isJSXElement` - Replaced `Computable` and `ProcessedComputable` with the vue built-ins `MaybeRefOrGetter` and `MaybeRef` - `convertComputable` renamed to `processGetter` - Also removed `GetComputableTypeWithDefault` and `GetComputableType`, which can similarly be replaced - `dontMerge` is now a property on rows and columns rather than an undocumented css class you'd have to include on every feature within the row or column - Fixed saves manager not being imported in addiction warning component - Created `vueFeatureMixin` for simplifying the vue specific parts of a feature. Passes the component's properties in explicitly and directly from the feature itself - All features should now return an object that includes props typed to omit the options object and satisfies the feature. This will ensure type correctness and pass-through custom properties. (see existing features for more thorough examples of changes) - Replaced decorators with mixins, which won't require casting. Bonus amount decorators converted into generic bonus amount mixin. Removed effect decorator - All `render` functions now return `JSX.Element`. The `JSX` variants (e.g. `renderJSX`) (except `joinJSX`) have been removed - Moved all features that use the clickable component into the clickable folder - Removed `small` property from clickable, since its a single css rule (`min-height: unset`) (you could add a small css class and pass small to any vue feature's classes property, though) - Upgrades now use the clickable component - Added ConversionType symbol - Removed setDefault, just use `??=` - Added isType function that uses a type symbol to check - General cleanup

thepaperpilot added 35 commits 2024-11-19 14:35:41 +00:00

Update fontsource dependencies 90300ce848

Update vite dependencies 8a9e106157

Bump some minor dependencies ae45f9bc2f

Switch from CJS to ESM 673f7790c7

Removed dynamic imports 6ba25f9abd

WIP on rewriting board 1cbe97251c

Add support for rendering VueFeatures in boards c64ac82a25

Add cnodes a75c8d81f8

Use z-index to avoid changing render order 6a17bbc29c

Perf optimization 5b33a0fceb

Fix upgrade purchasing on drag 8745304631

Document boards c6035f9077

Add some tests for boards 46d0a9aa2e

Move board to src/game e0da9588d2

Move common board node CSS to class 99227a2cb2

Revert changes in /data. Check the board-example branch for them instead f9c59f7636

Add link to docs in setupDraggableNode docstring 643bfccada

Revert "Add link to docs in setupDraggableNode docstring" 1e13da1129

This reverts commit 1c7824b550.

Update vitest 707aacc383

Update pixi (while staying at v6 until particle-emitter supports v8) dc8d0ecc95

Update vue 2dab35f7cf

Update TS 80d7a743bc

Update eslint and prettier 88abd53faf

Fix merge c93418bfec

Update deps some more

Run Tests / test (pull_request) Failing after 47s

Details

bd165da264

Fix build issues

Run Tests / test (pull_request) Failing after 58s

Details

052a01d3f7

Update container version

Run Tests / test (pull_request) Failing after 1m21s

Details

3eeff40910

Add rollup for linux

Run Tests / test (pull_request) Failing after 13s

Details

a676829d66

Remove node install

Run Tests / test (pull_request) Failing after 5s

Details

5ce3e64f5d

Update node

Run Tests / test (pull_request) Failing after 1m20s

Details

ccd685cb9c

Remove processedPropType and convert all components to composition API

Run Tests / test (pull_request) Failing after 1m8s

Details

1e5411d279

Remove _props abstraction (fixes #2 )

Run Tests / test (pull_request) Failing after 1m7s

Details

6c8dd66677

Ran lint:fix 528e703c88

Fix last lint issue

Run Tests / test (pull_request) Successful in 1m10s

Details

4987916900

Feature rewrite

Run Tests / test (pull_request) Failing after 1m16s

Details

1657dffcfe

- Removed `jsx()` and `JSXFunction`. You can now use `JSX.Element` like any other `Computable` value
- `joinJSX` now always requires a joiner. Just pass the array of elements or wrap them in `<>` and `</>` if there's no joiner
- Removed `coerceComponent`, `computeComponent`, and `computeOptionalComponent`; just use the `render` function now
- It's recommended to now do `<MyComponent />` instead of `<component :is="myComponent" />`
- All features no longer take the options as a type parameter, and all generic forms have been removed as a result
- Fixed `forceHideGoBack` not being respected
- Removed `deepUnref` as now things don't get unreffed before being passed into vue components by default
- Moved MarkNode to new wrapper, and removed existing `mark` properties
- Moved Tooltip to new wrapper, and made it take an options function instead of raw object
- VueFeature component now wraps all vue features, and applies styling, classes, and visibility in the wrapping div. It also adds the Node component so features don't need to
- `mergeAdjacent` now works with grids (perhaps should've used scss to reduce the amount of css this took)
- `CoercableComponent` renamed to `Renderable` since it should be used with `render`
- Replaced `isCoercableComponent` with `isJSXElement`
- Replaced `Computable` and `ProcessedComputable` with the vue built-ins `MaybeRefOrGetter` and `MaybeRef`
- `convertComputable` renamed to `processGetter`
- Also removed `GetComputableTypeWithDefault` and `GetComputableType`, which can similarly be replaced
- `dontMerge` is now a property on rows and columns rather than an undocumented css class you'd have to include on every feature within the row or column
- Fixed saves manager not being imported in addiction warning component
- Created `vueFeatureMixin` for simplifying the vue specific parts of a feature. Passes the component's properties in explicitly and directly from the feature itself
- All features should now return an object that includes props typed to omit the options object and satisfies the feature. This will ensure type correctness and pass-through custom properties. (see existing features for more thorough examples of changes)
- Replaced decorators with mixins, which won't require casting. Bonus amount decorators converted into generic bonus amount mixin. Removed effect decorator
- All `render` functions now return `JSX.Element`. The `JSX` variants (e.g. `renderJSX`) (except `joinJSX`) have been removed
- Moved all features that use the clickable component into the clickable folder
- Removed `small` property from clickable, since its a single css rule (`min-height: unset`) (you could add a small css class and pass small to any vue feature's classes property, though)
- Upgrades now use the clickable component
- Added ConversionType symbol
- Removed setDefault, just use `??=`
- Added isType function that uses a type symbol to check
- General cleanup