Loïc Dachary
8966a9ae39
[CI] Search .forgejo/workflows first
...
(cherry picked from commit 8b11cab677be59270696e068f8b1917855bb0c6045c4c8f44389520d67ff15eeb417a46db53a26432f689b321f
2023-08-01 08:26:38 +02:00
Earl Warren
5b8ae1e10b
[CI] disable minio test, no minio server yet in CI
...
(cherry picked from commit 0dd74d09d328d2d9b2123c3db1ff0f79bbbe2dd2a4050eb6b1d8fac17bbe1220a8e015e0beae09f0e4bf15eb95a6a4faf9c4336e35fdb9
2023-08-01 08:26:38 +02:00
Earl Warren
7061911d3f
[CI] disable redis test, no redis server yet in CI
...
(cherry picked from commit e1bbfa361991245ca917705d0558be92475949709db1158a483b36b77d87162fa1d8aed03d0afbb57b8f92f787035abca969a8fbf6bb56
2023-08-01 08:26:38 +02:00
Loïc Dachary
b9e7a54988
[CI] tests/pgsql.ini.tmpl: do not use minio
...
f92e0a40184cfbf4718d9bd644d601604636c7c4341cdb854057bdc91de5c6ec6517b42f03fc1b29aaecd109667025ff7b0615e6485ae15f7b23c659a74d7ce6c5f552e2fc569fa4a90baaa8be33da60205f7897aaa6074d765db85c999109e370e412e8
2023-08-01 08:26:38 +02:00
Loïc Dachary
a5ce64a4cf
[CI] set PASSWORD_HASH_ALGO = argon2 for integration tests
...
(cherry picked from commit 1d7ce2a39c3af87575830b818152097180a3222a069044f4a6dd1438f3894ae6b5d64dc572666d78de0a4480bc60272ef4f7a68fdde4beff448cf3a6208498caaa1abd3efad8818c7f4ca91e552bbe4488dbd6da1db1c86fb777185b1e25b10af35605ae350975b63f2788142515
2023-08-01 08:26:38 +02:00
Loïc Dachary
b4ed09daae
[CI] implementation: forgejo container images
...
(cherry picked from commit dd1971d4e63981dbaf8c8dff3cc2d1e7673e5d22326174064beb769dbde4335829ade25e8e4f549db777fc91d002cda642ec96ef93f3bcaa424551f2e54fa86e49043fa6d664805b16248086bf362a3c13e000795900ff6f7cb395c7d8e883fb033d2bb61147910a556590b6e99c78938113e4
2023-08-01 08:26:38 +02:00
Loïc Dachary
fda7f31fd7
[CI] Woodpecker based releases process
...
(cherry picked from commit c2a7aaeee86b6007fbce63608a221e5cfe60baa72af4c73d121985959bfe880424c77ec78a861d1b25c12270117195e894eecf151538739bee773c95581c3060dabf550f9b2cb570eca0b96308c776b693e42f3f53599c5162ad6f8b723a55e238d7d72f2258fb575b52195d9456633a61809e9ff1e2561d
2023-08-01 08:26:38 +02:00
Loïc Dachary
4839f1d293
[CI] implementation: publish forgejo- binaries instead of gitea-
...
(cherry picked from commit 6d910daafbd447861cc9dc6e9d8799ef232fa20c290c55517adb48af178485f33237a276899ee33e148b3ee9cb1f6ad8f465c330afdba3b1f87075a77da40992cc7ab19ff5e5e61e44921b83646119fb20cf748e610a99919cec21215222a60f6c5658d71752e43d3c2332080929590aabf2a2
2023-08-01 08:26:38 +02:00
Earl Warren
302c4e30ac
[CLI] implement forgejo-cli actions
...
(cherry picked from commit 08be2b226eb6cfa88c6e59704200de6f7905c8ece085d6d273962c944eb22f9514300042f2f8731e1ba7c0d39d6f7905c8ece085d6d273962c944eb24c121ef02236997a48e3https://codeberg.org/forgejo/forgejo/issues/1134
(cherry picked from commit 9739eb52d8
2023-08-01 08:26:36 +02:00
Earl Warren
af9e7d8e9e
[CLI] implement forgejo-cli
...
(cherry picked from commit 2555e315f751b9c9092e5c31ae602abbf76489a7d0dbe52e76https://pkg.go.dev/github.com/urfave/cli/v2
(cherry picked from commit b6c1bcc008
2023-08-01 08:24:56 +02:00
Earl Warren
5dc9aacfce
[CI] DEFAULT_ACTIONS_URL = https://codeberg.org
...
(cherry picked from commit 52b364ddbd99887cd567cd5788782a71c698a70471386241ddb7ab05aeace78b9ca59cedb3adf4603e40088197https://code.forgejo.org
(cherry picked from commit d0e4512c908ba6e047096349081044e06bd44495d58219d8e1052f2c2aa429dc3953869eef3f59f3d650391fedc2e6e8c55de28a47741dhttps://codeberg.org/forgejo/forgejo/issues/1062
(cherry picked from commit 74cc25376e405430708f
2023-08-01 08:24:56 +02:00
Earl Warren
08848605f0
[CI] Revert "Restrict [actions].DEFAULT_ACTIONS_URL to only github or self ( #25581 )"
...
This reverts commit 67bd9d4f1e0547e94023d21ad654adb905e9d838
2023-08-01 08:24:56 +02:00
Loïc Dachary
e0ede14564
[TESTS] MockVariable temporarily replaces a global value
...
defer test.MockVariable(&variable, 1234)()
(cherry picked from commit 9c78752444d7795d7b25d0ffbd112cf3e62a57bf
2023-08-01 08:24:56 +02:00
Denys Konovalov
b9baed2c74
Introduce flex-list & flex-item elements for Gitea UI ( #25790 )
...
This PR introduces a new UI element type for Gitea called `flex-item`.
It consists of a horizontal card with a leading, main and trailing part:
The idea behind it is that in Gitea UI, we have many cases where we use
this kind of layout, but it is achieved in many different ways:
- grid layout
- `.ui.list` with additional hacky flexbox
- `.ui.key.list` - looks to me like a style set originally created for
ssh/gpg key list, was used in many other places
- `.issue.list` - created for issue cards, used in many other places
- ...
This new style is based on `.issue.list`, specifically the refactoring
of it done in #25750 .
In this PR, the new element is introduced and lots of templates are
being refactored to use that style. This allows to remove a lot of
page-specific css, makes many of the elements responsive or simply
provides a cleaner/better-looking way to present information.
A devtest section with the new style is also available.
<details>
<summary>Screenshots (left: before, right: after)</summary>
</details>
---------
Co-authored-by: Giteabot <teabot@gitea.io>
2023-08-01 00:13:42 +02:00
Denys Konovalov
fc6c3d626e
Mention devtest in frontend contributing guidelines ( #26249 )
...
Our `devtest` page contains some good UI examples which should be taken
as example when working on Gitea UI. Mention it in our frontend
contributing guidelines to for new contributors to know about it.
2023-07-31 12:49:21 +02:00
Panagiotis "Ivory" Vasilopoulos
d58c542579
Add 'Show on a map' button to Location in profile, fix layout ( #26214 )
...
Not too important, but I think that it'd be a pretty neat touch.
Also fixes some layout bugs introduced by a previous PR.
---------
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-authored-by: Caesar Schinas <caesar@caesarschinas.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-07-31 08:44:45 +00:00
silverwind
72363be7ca
Use shared template for webhook icons ( #26242 )
...
Fixes: https://github.com/go-gitea/gitea/issues/26241
2023-07-31 08:00:52 +00:00
silverwind
7e160f8824
Reduce margins on user settings page, introduce flex-container ( #26046 )
...
Same as https://github.com/go-gitea/gitea/pull/26026 but for the user
settings page. It introduces a new `flex-container` class and shares it
across both pages.
Before and After:
<img width="1264" alt="Screenshot 2023-07-21 at 19 35 57"
src="https://github.com/go-gitea/gitea/assets/115237/1358dab4-55c0-40ce-a4d5-673099304f3d ">
<img width="1269" alt="Screenshot 2023-07-21 at 19 35 42"
src="https://github.com/go-gitea/gitea/assets/115237/34812f6d-dc65-4009-b977-90e03efdc6d1 ">
2023-07-31 07:16:03 +00:00
Jason Song
1e76a824bc
Refactor and enhance issue indexer to support both searching, filtering and paging ( #26012 )
...
Fix #24662 .
Replace #24822 and #25708 (although it has been merged)
## Background
In the past, Gitea supported issue searching with a keyword and
conditions in a less efficient way. It worked by searching for issues
with the keyword and obtaining limited IDs (as it is heavy to get all)
on the indexer (bleve/elasticsearch/meilisearch), and then querying with
conditions on the database to find a subset of the found IDs. This is
why the results could be incomplete.
To solve this issue, we need to store all fields that could be used as
conditions in the indexer and support both keyword and additional
conditions when searching with the indexer.
## Major changes
- Redefine `IndexerData` to include all fields that could be used as
filter conditions.
- Refactor `Search(ctx context.Context, kw string, repoIDs []int64,
limit, start int, state string)` to `Search(ctx context.Context, options
*SearchOptions)`, so it supports more conditions now.
- Change the data type stored in `issueIndexerQueue`. Use
`IndexerMetadata` instead of `IndexerData` in case the data has been
updated while it is in the queue. This also reduces the storage size of
the queue.
- Enhance searching with Bleve/Elasticsearch/Meilisearch, make them
fully support `SearchOptions`. Also, update the data versions.
- Keep most logic of database indexer, but remove
`issues.SearchIssueIDsByKeyword` in `models` to avoid confusion where is
the entry point to search issues.
- Start a Meilisearch instance to test it in unit tests.
- Add unit tests with almost full coverage to test
Bleve/Elasticsearch/Meilisearch indexer.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-07-31 06:28:53 +00:00
JakobDev
aba9096999
Show image size on view page ( #25884 )
...
This simply shows the Image size on the view page. This is useful, if
you search a image with a specific size.
2023-07-31 05:04:45 +00:00
caicandong
983167cf49
Fix pull request check list is limited ( #26179 )
...
In the original implementation, we can only get the first 30 records of
the commit status (the default paging size), if the commit status is
more than 30, it will lead to the bug #25990 . I made the following two
changes.
- On the page, use the ` db.ListOptions{ListAll: true}` parameter
instead of `db.ListOptions{}`
- The `GetLatestCommitStatus` function makes a determination as to
whether or not a pager is being used.
fixed #25990
2023-07-31 02:21:09 +00:00
JakobDev
ea385f5d39
Fix API leaking Usermail if not logged in ( #25097 )
...
The API should only return the real Mail of a User, if the caller is
logged in. The check do to this don't work. This PR fixes this. This not
really a security issue, but can lead to Spam.
---------
Co-authored-by: silverwind <me@silverwind.io>
2023-07-31 01:18:38 +00:00
GiteaBot
7dc2e50113
[skip ci] Updated licenses and gitignores
2023-07-31 00:32:16 +00:00
KN4CK3R
d08ab7be9c
Fix typo in metadata ( #26207 )
...
https://github.com/go-gitea/gitea/pull/26194#discussion_r1277094525
There is no need to backport because these names are just used internal.
2023-07-30 23:54:22 +00:00
silverwind
8e644d3460
Update js and py dependencies ( #26243 )
...
- Update all JS and PY dependencies minus
`eslint-plugin-eslint-comments` (because of
https://github.com/eslint-community/eslint-plugin-eslint-comments/issues/89 )
- Regenerate SVGs
- Remove depreacted eslint rule
- Tested mermaid and swagger
2023-07-31 01:16:12 +02:00
silverwind
04d7ced063
De-emphasize issue sidebar buttons ( #26171 )
...
I find the colored buttons in the issue sidebar distracting, given that
they are not primary actions, I think we can de-colorize them.
Before:
<img width="285" alt="Screenshot 2023-07-26 at 19 42 22"
src="https://github.com/go-gitea/gitea/assets/115237/7e784805-4e01-4199-94bb-0538a0130264 ">
<img width="288" alt="Screenshot 2023-07-26 at 19 43 06"
src="https://github.com/go-gitea/gitea/assets/115237/3a89c661-e24a-4ebf-a585-d404d0a6a78a ">
<img width="285" alt="Screenshot 2023-07-26 at 19 44 36"
src="https://github.com/go-gitea/gitea/assets/115237/c1aa8c13-6f41-4763-8149-d1c07cb4be5c ">:
After:
<img width="286" alt="Screenshot 2023-07-26 at 19 42 04"
src="https://github.com/go-gitea/gitea/assets/115237/74d640c2-e0ab-4fef-87aa-9e788e9010e2 ">
<img width="285" alt="Screenshot 2023-07-26 at 19 42 51"
src="https://github.com/go-gitea/gitea/assets/115237/3b69976a-9aa4-4e1c-8df3-4168f4a9fcf9 ">
<img width="286" alt="Screenshot 2023-07-26 at 19 45 15"
src="https://github.com/go-gitea/gitea/assets/115237/897222fd-4df2-4d99-98eb-e5f8fb77c4d6 ">
2023-07-30 22:46:53 +00:00
silverwind
aa723dea9b
Don't autosize textarea in diff view ( #26233 )
...
Resizing the comment editor can be a very expensive operation because it
triggers page reflows, which on large PRs can take upwards of seconds to
complete. Disable this mechanism on the diff page only where we know
that the page can get large.
Fixes https://github.com/go-gitea/gitea/issues/26201 for the textarea
editor.
I don't think this can be fixed for EasyMDE because as far as I can
tell, it exposes no option to disable this resizing.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
2023-07-31 00:11:15 +02:00
silverwind
4244ce0d28
Add /public/assets to .ignore ( #26232 )
...
Ignore compiled assets when searching via ripgrep and similar search
tools.
2023-07-30 12:34:20 +02:00
silverwind
72d89eb8dd
Fix attachment clipboard copy on insecure origin ( #26224 )
...
Fixes: https://github.com/go-gitea/gitea/issues/26202
Actually later I found out the code did not use `clippie`, so I fixed
it. The bug was never in the clippie module like I initially suspected.
Also, I added a tooltip for feedback.
<img width="139" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/da501670-9c15-4412-969a-b559773c7ab9 ">
---------
Co-authored-by: Giteabot <teabot@gitea.io>
2023-07-30 00:56:45 +02:00
puni9869
11074258fc
Fix commit compare style ( #26209 )
...
as title
Fixes : #25825
Before
<img width="1334" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/c54a41b0-39bd-4094-a956-081a8f4128f2 ">
After change
<img width="1340" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/c112d235-6bbe-4bcb-9529-78da3ab0fa14 ">
Co-authored-by: Giteabot <teabot@gitea.io>
2023-07-29 16:19:12 +00:00
caicandong
fd836ff68b
Fix unable to display individual-level project ( #26198 )
...
As title
Before:
After:
fix #26189
2023-07-29 15:35:53 +00:00
Zettat123
b33cf4fabc
Fix access check for org-level project ( #26182 )
...
Fix #25934
Add `ignoreGlobal` parameter to `reqUnitAccess` and only check global
disabled units when `ignoreGlobal` is true. So the org-level projects
and user-level projects won't be affected by global disabled
`repo.projects` unit.
2023-07-29 14:13:24 +00:00
Kerwin Bryant
05d0b7ca91
Fixed incorrect locale references ( #26218 )
...
Fixed two incorrect headers for setting the page navigation bar:
* User settings page, should not use the title "`org.settings`"
* Repo settings page, should not use the title "`org.settings`"
2023-07-29 21:34:22 +08:00
Panagiotis "Ivory" Vasilopoulos
1c89f15f42
Use calendar icon for Joined on... in profiles ( #26215 )
2023-07-29 19:34:49 +08:00
delvh
e01824f2b8
Add changelog for 1.20.2 ( #26208 )
...
Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-07-29 15:07:03 +08:00
sebastian-sauer
55532061c8
Add commits dropdown in PR files view and allow commit by commit review ( #25528 )
...
This PR adds a new dropdown to select a commit or a commit range
(shift-click like github) of a Pull Request.
After selection of a commit only the changes of this commit will be shown.
When selecting a range of commits the diff of this range is shown.
This allows to review a PR commit by commit or by viewing only commit ranges.
The "Show changes since your last review" mechanism github uses is implemented, too.
When reviewing a single commit or a commit range the "Viewed" functionality is disabled.
## Screenshots
### The commit dropdown
### Selecting a commit range
### Show changes of a single commit only
### Show changes of a commit range
Fixes https://github.com/go-gitea/gitea/issues/20989
Fixes https://github.com/go-gitea/gitea/issues/19263
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
2023-07-28 21:18:12 +02:00
puni9869
4971a10543
Warn instead of reporting an error when a webhook cannot be found ( #26039 )
...
Attemp fix : #25744
Fixing the log level when we delete any repo then we get error hook not
found by id. That should be warn level to reduce the noise in the logs.
---------
Co-authored-by: delvh <dev.lh@web.de>
2023-07-28 17:46:48 +00:00
puni9869
1d8d90fd37
Fixing the align of commit stats in commit_page template. ( #26161 )
...
Fixing the align center to row and space around for commit_page
template.
2023-07-28 13:12:44 -04:00
Lunny Xiao
ce27de4d48
Fix allowed user types setting problem ( #26200 )
...
Fix #25951
2023-07-28 12:15:39 -04:00
wxiaoguang
d88fed0db1
Hide branch/tag icon if branches/tags are empty ( #26204 )
...
The branch/tag icons aren't hidden correctly if there is no branch/tag. This PR fixes it.
2023-07-28 23:05:24 +08:00
KN4CK3R
7866a6e0e2
Prevent primary key update on migration ( #26192 )
...
Fixes #25918
The migration fails on MSSQL because xorm tries to update the primary
key column. xorm prevents this if the column is marked as auto
increment:
c622cdaf89/internal/statements/update.go (L38-L40)
2023-07-28 09:54:31 +02:00
Earl Warren
494ee56de2
improve unit test for caching ( #26185 )
...
- Configure `setting.CacheService.TTL` which will force the code to go
trough the caching mechanism.
- Remove the TODO and uncomment the test code.
(cherry picked from commit a201f2f189https://codeberg.org/forgejo/forgejo/pulls/974
---------
Co-authored-by: Gusted <postmaster@gusted.xyz>
2023-07-27 22:24:40 +02:00
Earl Warren
eaea530d6b
Render plaintext task list items for markdown files ( #26186 )
...
- The library that's being used for org-mode, [doesn't render the status
of list items](https://github.com/niklasfasching/go-org/issues/63 ).
- Add a modified version of the proposed CSS snippet to still display
the status for the list items. The alternative was parsing HTML and
transforming it, which is too complicated for this small task.
- Resolves https://codeberg.org/Codeberg/Community/issues/1099
(cherry picked from commit 9753c7e4b8https://codeberg.org/forgejo/forgejo/pulls/1071
Co-authored-by: Gusted <postmaster@gusted.xyz>
2023-07-27 14:15:31 +00:00
puni9869
16afe4f631
Add tooltip to describe LFS table column and color delete LFS file button red ( #26181 )
...
Fix: https://github.com/go-gitea/gitea/issues/26152
Thease changes are related to UX and accessibility changes in desktop
mode.
<img width="50" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/30a75b50-4f8d-4108-9219-2c69b2a8fa6f ">
Also this is incomplete header
<img width="264" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/87837076-dfc7-4a68-863a-795edf61eb02 ">
Lets add a tooltip if it is applicable or add `title` attribute so that
it will be clearly visible.
After
2023-07-27 13:39:09 +00:00
delvh
bd6ef71854
Show branches and tags that contain a commit ( #25180 )
...
Now, you can see for a commit which existing branches and tags contain it.
You first have to click on the `load branches and tags` button, they are not preloaded by default.
All branches and tags are ordered descending by creation date.
You can even see without much hassle if the given commit is already part of the default branch.
Closes #25152
## Screenshots
### Initial
### Loaded
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-07-27 12:47:41 +02:00
Lunny Xiao
bd7b5e61aa
Release attachments duplicated check ( #26176 )
2023-07-27 09:24:22 +00:00
wxiaoguang
8baa42c8d7
Calculate MAX_WORKERS default value by CPU number ( #26177 )
...
To avoid consuming user's 100% CPU, limit the default value of
MAX_WORKERS
Fix #26063 (the CPU 100% problem mentioned in it)
2023-07-27 16:40:35 +08:00
cassiozareck
73fb1ecdcf
Fixing redirection issue for logged-in users ( #26105 )
...
This PR addresses an issue where logged-in users get redirected to the
homepage when trying to access a URL with the redirect_to parameter. The
issue was traced back to a middleware function in
services/auth/middleware.go that redirects logged-in users to the
homepage. This function didn't account the redirect_to parameter.
The fix modifies the middleware function to check for this case and
redirect the user to the specified URL instead of the homepage.
Closes : #26005
---------
Signed-off-by: cassiozareck <cassiomilczareck@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-07-27 13:08:51 +08:00
silverwind
c6975e583a
Update govulncheck, fix typo ( #26168 )
...
- Update govulncheck to latest version
- Fix typo in variable name
2023-07-26 22:51:02 +00:00
KN4CK3R
2d7fe4cc1e
Fix handling of plenty Nuget package versions ( #26075 )
...
Fixes #25953
- Do not load full version information (v3)
- Add pagination support (v2)
2023-07-26 19:43:21 +00:00
